ModManagerMC / ModManager

A ModManager extension for ModMenu
Apache License 2.0
79 stars 11 forks source link

[BUG] Toast shows incorrect mod count (race condition) #108

Closed Hexcede closed 2 years ago

Hexcede commented 2 years ago

Describe the bug When loading the game, the toast can display before all mods have actually been checked for updates. This results in the toast showing an incorrect number of mods (e.g. 3), but when entering the menu there are actually more (e.g. 13, I have a lot of mods that don't respect semver apparently).

To Reproduce Steps to reproduce the behavior:

  1. Install a few mods which don't respect semver or have multiple out of date mods
  2. Launch the game so that the toast will display
  3. Sometimes the correct count is displayed but usually if the game window is focused it will pop up immediately with an incorrect count

Expected behavior The toast displays the correct number of mods.

Screenshots Incorrect number of mods displayed: image

Outdated mods in manager (There are 13): image

Please complete the following information:

DeathsGun commented 2 years ago

Yeah I noticed that one too but haven't had time to track it down Thank you for finding the reason for that one

DeathsGun commented 2 years ago

This should fix your problem: modmanager-1.2.0-alpha+1.17.jar.zip