ModManagerMC / ModManager

A ModManager extension for ModMenu
Apache License 2.0
79 stars 11 forks source link

Backport to 1.16.5 #12

Open justlukie opened 3 years ago

justlukie commented 3 years ago

Is a backport to 16 out of the question?

DeathsGun commented 3 years ago

Currently not but if there is demand this can be backported

justlukie commented 3 years ago

Currently not but if there is demand this can be backported

good enough for me

DeathsGun commented 3 years ago

I have ported it to 1.16.5 but is has some bugs with the category list

xSaVageAU commented 3 years ago

Will there be a release for this port on here? I'd love to test it bugs or not

DeathsGun commented 3 years ago

I can upload you a build here when I'm home.

DeathsGun commented 3 years ago

Here it is:

modmanager-1.1.0-alpha+1.16.jar.zip

xSaVageAU commented 3 years ago

Thankyou so much!!! I guess i'm one of the first people to try this hey :P my friend will be really happy if this works even to some degree as he hates browsing on modrinth and having to update buggy mods.

xSaVageAU commented 3 years ago

So installing the mod was unsuccessful. I tried on Curse and of course they don't have the latest Kotlin or Fabric version. I installed the latest Kotlin from modrinth and installed fabric 0.11.7 and the game doesnt start. Is there something i'm missing?

These are the versions i have installed. I'm also using using Adoptium OpenJDK 16 if that matters Screenshot_2

This is the "crash log" https://pastebin.com/CANXZ4Zu

DeathsGun commented 3 years ago

The log is not complete

DeathsGun commented 3 years ago

You need to start minecraft and when it crashes upload latest.login the logs directory

xSaVageAU commented 3 years ago

Oh my bad! https://pastebin.com/a88jhEiL here it is I just assumed the latest text folder had the whole latest log lol

xSaVageAU commented 3 years ago

That first one is the latest.log file. thats all it gave me

DeathsGun commented 3 years ago

Ok that version isn't working because I'm using Java 16 features but minecraft 1.16.5 is only for Java 8

xSaVageAU commented 3 years ago

Ok good to know what the problem was so fast! So does that mean it just wont work or will it work with java 8 installed instead?

DeathsGun commented 3 years ago

Oh thats something you can't fix I need to change all Java 16 features to Java 8's features

xSaVageAU commented 3 years ago

Ok no worries :) Can't wait to try it :) Thanks again for letting me try it out i actually enjoy troubleshooting this stuff lol

obp3ter commented 3 years ago

I took a look, there's not much from what I can see, mostly the http client(and only in 3 classes), because you have that only from java 11 and up. I had some problems with gradle, so I can't fix it for you right now.

DeathsGun commented 3 years ago

Oh you need to change the loom version from 0.9-SNAPSHOT to 0.7-SNAPSHOT also some methods for in the Config class need to be adjusted

DeathsGun commented 3 years ago

I have ported it to 1.16.5 it probably has some bugs but it should work for the most part:

modmanager-1.1.0-alpha+1.16.jar.zip

obp3ter commented 3 years ago

I'll give it a try right now

obp3ter commented 3 years ago

Some mods can't be updated no matter what, some are not recognized as being installed(I'm guessing, the ones that were installed from curseforge), and the buttons look weird: image But other than that, good job, I'm very happy, that it's available for 1.16 as well.

DeathsGun commented 3 years ago

Have you bedrockify installed?

obp3ter commented 3 years ago

No, here are my mods, but it doesn't matter, I'll still be using it as it is.

obp3ter commented 3 years ago

Oh, and the ds is missing image

DeathsGun commented 3 years ago

Yeah thats an scaling issue which is also a bug in the 1.17.1 version

DeathsGun commented 2 years ago

Here is a new test version for 1.16.5! It's based on the 1.2.0 Branch with some patches. For this one you will need:

modmanager-1.2.0+1.16.jar.zip

obp3ter commented 2 years ago

It was compiled with java 16.

DeathsGun commented 2 years ago

Oh my bad I missed that one. I will need some time to change HTTP specific code because it uses the Java 11 HttpClient

DeathsGun commented 2 years ago

Fixed it here is a new build: modmanager-1.2.0+1.16.jar.zip

obp3ter commented 2 years ago

I finally managed to update to fabric 12 and test this out. It works well, as far as I can see. The problem with versions being offered beeing older than the one installed is still a problem, but when I have more time, probably next year I'll look into it.

DeathsGun commented 2 years ago

I'm working currently on a fix for that one which is more detailed here #101 which will also gets backported to 1.16

obp3ter commented 2 years ago

Nice. Although thats not exactly what I meant. Yeah I also have a few mods where it differes a bit but it's the same version. I was thinking more about mods where it thinks that 2.10.11 is older than fabric-2.10.2. The same fix could apply if you are thinking about comparing not only what's the latest on modrinth but still it's a bit annoying.

DeathsGun commented 2 years ago

Hey i just merged all the 1.17 and 1.18 features into 1.16 can anyone test this version a little bit more extensively? modmanager-1.2.0+1.16.zip

obp3ter commented 2 years ago

Nice. I don't really have a lot of time this week, but at the latest, during the weekend I can test it a bit.

obp3ter commented 2 years ago

Screenshot (113) Notifications keep popping up for me. And the number isn't even accurate. I had 5 updates available when I opened that tab.

obp3ter commented 2 years ago

Nice. Although thats not exactly what I meant. Yeah I also have a few mods where it differes a bit but it's the same version. I was thinking more about mods where it thinks that 2.10.11 is older than fabric-2.10.2. The same fix could apply if you are thinking about comparing not only what's the latest on modrinth but still it's a bit annoying.

And this is still there

DeathsGun commented 2 years ago

With 1.2.2?

luni3359 commented 2 years ago

I'm also experiencing that pop up on minecraft 1.18.1 on version 1.2.1, although the count seems to be correct.

https://user-images.githubusercontent.com/16832398/149229726-72c7b9f4-0e34-431e-b166-585ed6ecfa26.mp4

luni3359 commented 2 years ago

There's no more notifications spam on 1.2.2!

obp3ter commented 2 years ago

So I managed to have a look at the newer version. I didn't notice, that you started making releases. The notification bug is not there anymore, but the versioning issue is. And now it is taking very very long until the mod looks for updates, and while doing so it consumes a lot of resources. My animated background is lagging while ModManager is looking for updates.

luni3359 commented 2 years ago

I'm also having other issues, but I think we'd better make a separate issue for those.

DeathsGun commented 2 years ago

And now it is taking very very long until the mod looks for updates, and while doing so it consumes a lot of resources. My animated background is lagging while ModManager is looking for updates.

Yeah I need to investigate that one, but I think it has something to do with the race condition fix