search

ModManagerMC / ModManager

A ModManager extension for ModMenu
Apache License 2.0
79 stars 11 forks source link

[BUG] NullPointerException is often thrown when update a mod #34

Closed RoboMico closed 3 years ago

RoboMico commented 3 years ago

Describe the bug Mod updating often fails and throw a NullPointerException in Show error page. I tried to update 4 mods and this issue happened twice.

To Reproduce This error has a random chance to happen and not every try will reproduce it.

  1. Get a mod need to be updated;
  2. Open ModManager menu;
  3. Double click the outdated mod and click Update;
  4. A button "Show error" appears, click in and see the error.

Screenshots Tested fail-to-update mods: image

Error report: image

Two mods have the same report content.

Please complete the following information:

Logs Latest log: latest.log Mod list: modlist.txt

Crash report (if any): no crashes

DeathsGun commented 3 years ago

Thank you for the report I will look into it

DeathsGun commented 3 years ago

Does this fix your problem? Artifacts.zip

RoboMico commented 3 years ago

Does this fix your problem? Artifacts.zip

Detail Armor Bar doesn't give errors any more, but Reese's Sodium Options reports a new one: image

Logs: latest.log

I guess it is caused by the renaming of the mod(it's called Sodium Extra in my mods folder).

RoboMico commented 3 years ago

Also there is a small bug, sometimes the update will download a Forge version of a mod. image Would you mind me opening another issue?

DeathsGun commented 3 years ago

It should find it because it ignores the file name an checks only the fabric.mod.json provided by the mod developer. I think it messes Sodium Extra and Sodium Options up

DeathsGun commented 3 years ago

Also there is a small bug, sometimes the update will download a Forge version of a mod. image Would you mind me opening another issue?

Yes please