ModManagerMC / ModManager

A ModManager extension for ModMenu
Apache License 2.0
79 stars 11 forks source link

[BUG] Error on console when launching with figura mod #70

Closed davidalb97 closed 3 years ago

davidalb97 commented 3 years ago

Describe the bug Installing figura mod causes an error on the log when running with mod manager:

[DefaultDispatcher-worker-2/INFO]: No update for modmanager found!
[DefaultDispatcher-worker-4/INFO]: No update for modmenu found!
[DefaultDispatcher-worker-4/INFO]: [STDERR]: java.lang.NullPointerException: Cannot invoke "net.fabricmc.loader.api.SemanticVersion.getVersionComponentCount()" because "o" is null
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at net.fabricmc.loader.util.version.SemanticVersionImpl.compareTo(SemanticVersionImpl.java:228)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at xyz.deathsgun.modmanager.update.VersionFinder.findUpdateByVersion$modmanager(VersionFinder.kt:72)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at xyz.deathsgun.modmanager.update.VersionFinder.findUpdate(VersionFinder.kt:85)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at xyz.deathsgun.modmanager.update.UpdateManager.checkForUpdatesManually(UpdateManager.kt:148)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at xyz.deathsgun.modmanager.update.UpdateManager.access$checkForUpdatesManually(UpdateManager.kt:56)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at xyz.deathsgun.modmanager.update.UpdateManager$checkUpdates$2$1$1.invokeSuspend(UpdateManager.kt:76)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
[DefaultDispatcher-worker-4/INFO]: [STDERR]:    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

To Reproduce Steps to reproduce the behavior:

  1. Install mods from modlist bellow
  2. Launch minecraft

Expected behavior No error on the console.

Please complete the following information:

Mod list:

Logs Latest log: https://pastebin.com/H4WpdXa3

Crash-report (if any): none

DeathsGun commented 3 years ago

Does this version fix your problem?

modmanager-1.1.0-alpha+1.17.jar.zip

davidalb97 commented 3 years ago

Yes, the problem is fixed, however, the version 1.1.0-alpha that I was using from modrinth (and still has the error) had a SHA1: c9a267f6be2605f097247a24e19444ab8396fcc2, while the version you just gave me from github releases has a SHA1: 927fd494cf44f53022888ab93078eb69be24fac7.

Is the modrinth page yours?

DeathsGun commented 3 years ago

yes i gave you a build of #71

davidalb97 commented 3 years ago

Thanks for clearing it out, was getting a little bit confused :+1:

DeathsGun commented 3 years ago

No problem