search

ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.19k stars 163 forks source link

MO2 accepts invalid ModuleConfig.xml #1050

Closed Dark-Dominion closed 4 years ago

Dark-Dominion commented 4 years ago

MO2 accepts invalid ModuleConfig.xml inside the FOMOD Folder. Even with missing lines of code it still functions.

Mods posted with these invalid FOMODs will not function on NMM and Vortex ( and I guess not on Wrye Bash, not confirmed )

MO2 needs some sort of generic .xml library to check if the provided ModuleConfig.xml is valid.

Karandra commented 4 years ago

What missing lines of code? Can you upload an example of such ModuleConfig.xml file?

Dark-Dominion commented 4 years ago

ModuleConfig.zip

In the attached ModuleConfig.xml the bold / greenlines are sometimes missing. These lines are mandatory in a .xml file. Without these lines MO2 still installs the files in the FOMOD, other MOs don't.

**** ** **
Dark-Dominion commented 4 years ago

MO2

Karandra commented 4 years ago

Now I see. These options aren't mandatory for FOMod to function properly but they're defined as mandatory in XML scheme. NMM and Vortex validates FOMod's XML against the scheme, MO2 and other mod mangers don't.

Karandra commented 4 years ago

MO2 would need to use an XML scheme validator to catch these. I personally don't think MO2 need to discard such FOMods but it can show a warning when the config doesn't pass XML scheme validation.

isanae commented 4 years ago

Not a bug.