ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.19k stars 163 forks source link

Mod Configuration Menu (MCM) not working unless you place stuff into real Data/MCM #129

Closed blubberdiblub closed 6 years ago

blubberdiblub commented 6 years ago

I'm testing with Fallout 4. I'm using the MO2 2.1 build from 2017-11-10. I also use the updated python boost dll and the usvfs dlls that were posted to #testers on Discord on 2017-11-11. System is Windows 10 (Build 16299).

The starting point is both the current Mod Configuration Menu as well as the MCM Demo plugin installed - each as separate Mod in the MO2 list and both activated and no files removed from them in any of the following cases.

Furthermore, the overwrite directory is empty (i. e. contains no MCM\Config directory or the like).

Basically one of 3 observations arise, depending on what I put into the real Data folder of Fallout 4:

I also had a fourth case during testing related to the Settings directory that mixed it all up, where all except the plugin's entry appeared, but I cannot reproduce that. I'm not sure whether I did something wrong or there's some kind of mandelbug in the mix.

Directory or File 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
Data\MCM ⬜️
Data\MCM\Settings ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Settings\readme.txt ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Config ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Config\MCM ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Config\MCM\settings.ini ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Config\MCM_Demo ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Data\MCM\Config\MCM_Demo\config.json ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️ ⬜️
Outcome A A A A B B B B B B B B B B B B C C C

What that means is the existence of directory Data\MCM doesn't help at all. However, the existence of directory Data\MCM\Config makes at least the MCM Config appear in the pause menu, albeit with an empty list in its own menu. Only the config.json of the MCM plugins under Data\MCM\Config\Plugin_Name\config.json makes everything appear as desired.

Modulo the case with only the built-in entries being available which I wasn't able to reproduce.

blubberdiblub commented 6 years ago

Here is the usvfs.log from the first case. (I can also provide the log files from the other cases if needed.)

usvfs-00000000.log

Don't mind the funny name suffix - it was just my way to organize them.

wyrde commented 6 years ago

I noticed when looking through my own usvfs log that some of the files in the mcm tree were being included in the vfs but not the .json files.

I decided to take a closer look and did the thing where I start a cmd window which in turn runs f4se_loader and starts FO4. I wandered through the data\mcm tree and all the files were there. But when I looked in the usvfs log, none of the .json files had entries. Most of the .ini files were in the log, but not all of them.

In the case of XDI, data\MCM\Config\XDI seems to be created, but is not populated.

(I underlined in red for each file I found) image

I'm not sure if cmd.exe is getting the usvfs differently than FO4, but thought this was pretty strange.

PS: the thing (tm) https://pc.reddit.com/r/skyrimmods/comments/76yqm8/mo2_acts_really_odd_after_running_a_game/dohomez/

Silarn commented 6 years ago

Latest USVFS builds have addressed some of these issues. With the final changes for WryeBash, it's possible it works as expected now but it should with with just the config and settings directories created now.

Silarn commented 6 years ago

Until we can identify the 'nested directory' bug, you will have to create the basic directory structure for this (and possibly other) mods that search for files in nested directories.

In the case of MCM, adding MCM\Settings and MCM\Config should allow all MCM mods to work as expected without putting any actual files in the Data directory.

Silarn commented 6 years ago

LePresidente's latest USVFS change should fix any subdirectory search patterns. Closing this.