ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.15k stars 159 forks source link

Preselect FOMOD options when reinstalling #1699

Open Gitii opened 2 years ago

Gitii commented 2 years ago

Is your feature request related to a problem? Please describe. Each time I reinstall a mod (FOMOD installer), I have to remember which options I selected. For example, I recently reinstalled "Embers HD" which has this one option "NO artic frost", which needs to be selected when you DON'T use this particular mod. I always have trouble to remember which things I selected. Also annoying when I have to select patches. Sometimes I screenshotted parts of the installer, checked in MO and when do I final "perfect" run. Whenever I have to reinstall such a mod, I either have to do that again or hope that I remember everything.

Describe the solution you'd like FOMOD installers: When reinstalling a mod, it would be great if previously selected options could be preselected. For radio buttons and checkboxes.

Describe alternatives you've considered

Additional context

picobyte commented 2 years ago

Though reading xml files too long may cause spontaneous eye bleeding, the FOMod specs do provide the possibility to set defaults, so you can edit a FOMod Menuconfig.xml in the installer archive to set defaults. Sometimes options are based on dependencies (game version, installed or active mods) and MO2 should not override the author's defaults, no matter what the user chooses. In that case the author's defaults are usually the wisest choice, or you could try to mention them.

Due to the dependency complexity I don't think it's reasonable to expect of MO2 to choose for you. Naive users, that once chose unwisely and later learn to be more careful, may find the continuing of their past errors a non-feature.

Gitii commented 2 years ago

Hi @picobyte, thanks for taking your time and evaluating my feature request.

picobyte commented 2 years ago

Hi @Gitii, it was my opinion based on some knowledge of the FOMod specs, it seems not everyone agrees, because your feature request was reopened.

Al12rs commented 2 years ago

The feature would likely come in the form of asking the user whether they want to re-apply the previous choices when they select the "Reinstall" option on a particular mod.

So only when reinstalling and only if the user wants it, which hopefully avoids the problems mentioned by @picobyte (though we know that sometimes people don't read but there is just so much you can do there).

picobyte commented 2 years ago

sounds like a reasonable compromise.

Sceptrum commented 2 years ago

I was suggesting an alternative solution a couple of months ago on Discord. Dependencies and mod updates could cause issues to an auto-checking system, but what if MO2 just saves selected/unselected options and displays it in a new tab on the "Information" pane? With that, one can easily check not just what was chosen, but possible changes in case of an update.

Gitii commented 2 years ago

@Sceptrum But isn't the fomod installer a blocking window? You cannot use mo2 when an installer is active - another small detail that is driving me crazy because you cannot switch back to mo2 and check if you have other mods installed. That is usually the case for compatibility patches.

And when you figured it out and start the installer again, you have to remember all your other choices again.

Having the selected options in the Information tab is nice but neither can you see which other options are there (like in the installler) nor can you easily change only a single selection. You would have to memorize or screenshot it.

I still have some missing textures for my chandeliers because I do not want to go through this night mare of reverse engineering my selected options and then loading the game and hoping that I did everything right. I have a terrible memory 🙃

One issue with preselected options is that authors can define some conditional logic, if I understand the explanation @picobyte correctly. If I add or remove mods, the selection might actually be different (for example a compatibility patch is no longer required or a new one is necessary) - the old selection would overrule the author's one.

Some kind of indicator (adorner element) on the field would avoid that. And user would still know what he selected last time and the author's logic is preserved. You just need to select them again. It wouldn't even require user interaction. They can completely ignore it.

Sceptrum commented 2 years ago

@Gitii I see your point. There are still difficulties regarding this method. The reason why I was suggesting it, because from programming wise, it seems easier to implement. Right now, we have nothing. So any kind of help would be a huge support and if we would have a basic solution to check the options, we could go further from there towards the idea that you mentioned. Yours is superior, no question. But because of the problems that could arise, it would need much more time to develop, I reckon.

Holt59 commented 1 year ago

Duplicate of https://github.com/ModOrganizer2/modorganizer/issues/1083