ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.22k stars 161 forks source link

MO2 causes file enumeration to be reversed (Reminder) #217

Closed EsOmEs closed 5 years ago

EsOmEs commented 6 years ago

The problem

MO2 seems to reverse order of file enumeration from a->z to z->a. This becomes obvious when looking at the dropdown list for outfits/bodies in BodySlide or by looking at the plugin load order for skse in %Documents%\MyGames\Skyrim Special Edition\SKSE\skse64.log

Environment

Details

See the problem. for certain SKSE64 DLLs this seems to be a problem as they dont load after certain others. Even though this might not be an issue directly caused by MO2, it might cause lots of other problems.

Link to Mod Organizer logs

Not applicable.

USVFS

Not applicable

MO Interface

Not applicable

AnyOldName3 commented 6 years ago

Just in case this gets forgotten, a few people, myself included, have failed to replicate this when trying.

Silarn commented 6 years ago

Is there any recent case of this happening with the latest test build?

Silarn commented 6 years ago

There's is a possible cause for this in that the search hooks return results after the original results and without directories sorted to the top. This could cause issues with programs that return the results as is without any sorting.

However the fix will be complex and we don't know about any serious issues caused by this.

Al12rs commented 5 years ago

Apparently this combined with a SKSE issue and enough plugins can cause #377 Here is what LostDragonist found: https://discordapp.com/channels/265929299490635777/529544161750286359/538898232177328147

Al12rs commented 5 years ago

This commit https://github.com/ModOrganizer2/usvfs/commit/5f2493ab3c8526bcd32333537bf48aa079e6eaf1 should make sure to return the correct order but will most likely degrade performance. Since ntquery is pretty important and plenty used we should look for more performant alternatives with vectors