ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.18k stars 163 forks source link

[Enhancement] MO currently prioritizes FOMOD mod info but may need to prioritize available download info #328

Open finalsliver opened 6 years ago

finalsliver commented 6 years ago

The problem

meta.ini generated for LeanWolf's Better-Shaped Weapons for SkyrimSE generates with the Oldrim ModID. Meta.ini

The Mod URL is correct but this is ignored if users 'r-click' on a mod and choose 'visit on nexus', this feature seems to use the ModID field

Environment

Details

After manually fixing this field in the meta.ini, if I were to reinstall and choose replace then the file will reset to the original Oldrim ModID.

Link to Mod Organizer logs

USVFS

https://gist.github.com/finalsliver/c418888ffc30c1e2b0eba664df3a8fa0

MO Interface

https://gist.github.com/finalsliver/8d57b227eea9318df9adf2ec941f5e82

Silarn commented 6 years ago

This seems very strange to me since mo generates the URL based on your currently managed game. However the Dev builds have now included multi source game support for mods and downloads, so you might see if this still happens with those builds.

finalsliver commented 6 years ago

I assume this may be due to some Oldrim Mods being usable in SE?

In this case users trying to get to the above mods page will either pull up a completely different SkyrimSE mods page (as the mod ID's don't match the Oldrim ones) or pull up an error page as SSE hasn't reached that many mods to use the larger Oldrim ID.

It took me a bit of looking around to find that the meta.ini was related to the issue so some users may become rather confused.

Silarn commented 6 years ago

Generally MO gets the mod ID from the nxm link via the Nexus API for that game. How was this mod ID populated?

finalsliver commented 6 years ago

used the download with manager button on the SkyrimSE page. installed from within MO2

Silarn commented 6 years ago

Okay... Well I still have no idea why it would be linking to an oldrim page. The SSE download would pull all mod data from the SSE API endpoints, especially with the current release.

Silarn commented 6 years ago

(vs the dev builds)

Silarn commented 6 years ago

The mod ID can also be adjusted in the mod details if necessary.

Al12rs commented 6 years ago

I tested that mod and it seems to me that the author simply packaged the mod with the old nexus id and did not update it for SSE. MO will read the mod Id from the fomod installer if there is one set. So it's not a problem on Mo's side but more of a problem with the mod. Now that we have multiple source games support we can't set Mo to use the url instead for the "Visit on Nexus" since we need to be able to calculate it dynamically.

Silarn commented 6 years ago

Perhaps we should prioritize the mod ID from the download if it's set