ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.17k stars 161 forks source link

BSAs checked in "Archives" tab, but not loaded #459

Open FeuerTiger86 opened 6 years ago

FeuerTiger86 commented 6 years ago

The problem

I noticed that the BSAs from this mod were still checked in the "Archives" tab, even though there are no accompanying .esp files. Of course, they are not loaded by the game, as MO2 doesn't have the BSA management feature of the original MO. Then I noticed that when I disable a DLC, the corresponding BSA (e.g. "Dawnguard - HD.bsa") is also no longer checked in the "Archives" tab. This is also the case if the BSA is renamed. It appears that a BSA is automatically checked if it's file name contains a loaded .esp/.esm's file name at the beginning. This can lead to confusion because it may create the assumption that these BSAs are loaded by the game as well.

Environment

Link to Mod Organizer logs

https://gist.github.com/Pherim/e2c67831b3b28f67aad0bbc45f529367

LostDragonist commented 6 years ago

The archives tab does need some work.

The reason that an archive like "Skyrim - Misc.bsa" is loaded is because it's present in sResourceArchiveList or sResourceArchiveList2, not because Skyrim.esp is active. The archives checklist should better reflect this.

MO2 appears to be raising a warning if an archive is in one of the archive lists but is not activated by a plugin. This made sense with archive management but doesn't make sense right now. A user should be able to use those archive lists if they want.

The sorting order of the archives list appears to be in mod order. It should probably be in plugin order to better reflect the load order of the archives. The INI settings mentioned above probably need to be taken into account.

And, of course, that's how it should work for Skyrim and maybe Fallout 4. Other games might need to be investigated to see if they work the same or if some stuff needs to be different for each game.

FeuerTiger86 commented 6 years ago

I know that the default BSAs are loaded because of the ini lists. I'm not talking about these, though. The mod I was referring to (https://www.nexusmods.com/skyrim/mods/57353) is basically the official High-Res DLC with a few minor optimizations, but it doesn't come with esp files. There are two versions, one with a script that adds the BSAs to the ini lists, and one meant to be used with the MO BSA management feature. As I wrote above, I know that this no longer works in MO2. The BSAs were also not present in the list.

Once again, the BSAs were NOT loaded by the game, but they were still checked in the "Archives" tab, apparently because of their file names (Skyrim - HD01.bsa, Skyrim - HD02.bsa, Dawnguard - HD.bsa...). When I rename them or disable the corresponding DLC, they are no longer checked (to make myself absolutely clear, I am NOT talking about the original game's BSAs or those of the DLCs, but the ones from the mod above).

LostDragonist commented 6 years ago

Sorry, I was making notes about future development. What you described is completely true and is a problem.

FeuerTiger86 commented 6 years ago

Alright then, thank you.

Al12rs commented 6 years ago

There is a the possibility that the Achives tab will be cut completely when the BSA conflicts are ready. It doesn't serve much purpose and fixing it might require more effort than what it actually is worth.

LostDragonist commented 6 years ago

If the tab is removed, it'd be nice to add an "extract" option to the data tab for archive files. That's a pretty useful feature.

Al12rs commented 6 years ago

Yeah that should be added anyways

Zarggg commented 6 years ago

I do sometimes use the Archives tab to see whether I forgot to extract a BSA from a recently-installed or updated mod, so I would consider it helpful to have some kind of quick-reference BSA list going forward.

Silarn commented 6 years ago

It's also possible to bulk extract a mod's archive list with the archive tab.