ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.09k stars 158 forks source link

MO2 Profile plugins.txt Xedit issue #509

Closed RitualSSB closed 5 years ago

RitualSSB commented 5 years ago

The problem

Default profile suddenly cannot use Xedit due to it being unable to read plugins.txt

Environment

Details

is able to read other profiles, but reading the default profile, even if deleting and recreating plugins.txt causes issues. (not fixed by a reinstall of either Xedit or MO2)

LostDragonist commented 5 years ago

This issue has basically zero useful information. "Latest" is not a version as I can't trust that you know what the latest is. Hell, even I don't what the latest is. You have provided no logs.

The only possible guess I can make at this moment is that you have an anti-virus program that decided to mess with that particular file and none of the others.

RitualSSB commented 5 years ago

So I solved it. (After 6 hours of testing rip) it was a specific mod I downloaded. When disabled ssedit was able to load the archive. V strange. Anyways, the latest stable release of mo2 is 2.1.5 in case you get any other morons like me

Alexander Harrison Sent from Polymail ( https://polymail.io/?utm_source=polymail&utm_medium=referral&utm_campaign=signature )

On Fri, Aug 31, 2018 at 1:55 AM LostDragonist < LostDragonist ( LostDragonist notifications@github.com ) > wrote:

This issue has basically zero useful information. "Latest" is not a version as I can't trust that you know what the latest is. Hell, even I don't what the latest is. You have provided no logs.

The only possible guess I can make at this moment is that you have an anti-virus program that decided to mess with that particular file and none of the others.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub ( https://github.com/ModOrganizer2/modorganizer/issues/509#issuecomment-417559833 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AhNkO01Ws89-o32SORpTmE9Y80K8oCK5ks5uWM_MgaJpZM4WUof2 ).

LostDragonist commented 5 years ago

Any chance you can comment on which mod you think did this? Or which version of xEdit you were using?

RitualSSB commented 5 years ago

I checked with multiple versions of xedit. They all caused the issue. It had to do with a patch for blacksmith water fix (I think that’s what it’s called) that was flagged as an esl.

Alexander Harrison Sent from Polymail ( https://polymail.io/?utm_source=polymail&utm_medium=referral&utm_campaign=signature )

On Fri, Aug 31, 2018 at 2:00 AM LostDragonist < LostDragonist ( LostDragonist notifications@github.com ) > wrote:

Any chance you can comment on which mod you think did this? Or which version of xEdit you were using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub ( https://github.com/ModOrganizer2/modorganizer/issues/509#issuecomment-417560770 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AhNkOz1iqaaBM4d8Ok50x_ffBohbaNOXks5uWNEYgaJpZM4WUof2 ).

LostDragonist commented 5 years ago

If you have any idea what the patch was for, or have a link to the specific patch, I'd be eternally grateful. If mod can cause an error like this, we really need to know about it instead of just assuming it's a problem due to the mod.

Sharlikran commented 5 years ago

@aplanetsabc Was it Blacksmith Forge Water Fix - Special Edition?

I didn't install the files, but they are all .esp files, none are esl files.

RitualSSB commented 5 years ago

It had one flagged as an esl technically an esp-fe, (an esl flagged as an esl) i must have accidentally flagged it in ssedit and it corrupted something?

Alexander Harrison Sent from Polymail ( https://polymail.io/?utm_source=polymail&utm_medium=referral&utm_campaign=signature )

On Fri, Aug 31, 2018 at 2:18 AM Sharlikran < Sharlikran ( Sharlikran notifications@github.com ) > wrote:

@aplanetsabc ( https://github.com/aplanetsabc ) Was it Blacksmith Forge Water Fix - Special Edition ( https://www.nexusmods.com/skyrimspecialedition/mods/1291/ ) ?

I didn't install the files, but they are all .esp files, none are esl files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/ModOrganizer2/modorganizer/issues/509#issuecomment-417563627 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AhNkO9bHHnlhSl-HT8CmHyqmEPBtFZe5ks5uWNUbgaJpZM4WUof2 ).

Sharlikran commented 5 years ago

No I don't think you corrupted it. Someone that uses MO2 tested it and flagging an ESP with the ESL flag didn't cause that error. Which file, or patch exactly did you install there are three different files at that link. I also found many other patches when I searched with Google. Can you help provide a mod link and the file name?

RitualSSB commented 5 years ago

The patch that cause the error was the CRF patch in the main file download section

On Fri, Aug 31st, 2018 at 2:37 AM, Sharlikran notifications@github.com wrote:

No I don't think you corrupted it. Someone that uses MO2 tested it and flagging an ESP with the ESL flag didn't cause that error. Which file, or patch exactly did you install there are three different files at that link. I also found many other patches. Can you help provide a mod link and the file name?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/ModOrganizer2/modorganizer/issues/509#issuecomment-417566930 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AhNkOybWhwm6iFcWaqBYteniPygI_7j6ks5uWNmMgaJpZM4WUof2 ).

LostDragonist commented 5 years ago

It looks like this issue is due to a bug in xEdit that can corrupt plugins that have an error during saving. On the next load, the corrupt, 0 byte plugin throws the error as reported by the user.

The cause of the error was trying to flag a plugin as ESL when it contained invalid form IDs for ESL plugins. Assuming the plugin can be converted properly, the form IDs would need to compacted. (I think...)

Once again, this issue would have been much easier to diagnose had the user provided logs per the issue template. MO2 spits out an error "failed to parse plugin file : file incomplete" when it reads a 0KB file.

Sharlikran commented 5 years ago

This issue is fixed in commit https://github.com/TES5Edit/TES5Edit/commit/3ef7ff6c5b94742c638e8f18f2f4c32e8e533b6f