ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved

http://www.nexusmods.com/skyrimspecialedition/mods/6194

GNU General Public License v3.0

2.24k stars 163 forks source link

Fallout 3 - Strange error when installing an archive #612

Closed Yoplala closed 4 years ago

Yoplala commented 5 years ago

The problem

I'm trying to install this mod for Fo3: https://www.nexusmods.com/fallout3/mods/20035. He has an installer I don't know and at the installation with MO2, I have this message.

capture

The installation is going well anyway, everything seems to be there. It is actually an empty xml, but useful mod from what I understand. A MO2 error or this kind of installer?

On Discord, LostDragonist advised me to come here because it could be a MO2 problem.

Environment

Mod Organizer Version that exhibits the issue: 2.1.6 and 2.1.7
Last Mod Organizer Verison that did not exhibit the issue (if applicable):
Desktop OS/version used to run Mod Organizer: Windows 8

LostDragonist commented 5 years ago

I took a quick look at this when first reported. The installer is a C# script. The problem appears to be that the installer first tries to install includes_HUDMainMenu.xml and then tries to edit the file it just installed. This error occurs as it can't find or access the file (probably access given the error).

Yoplala commented 5 years ago

A friend tells me she doesn't have the problem with MO2, release 2.1.4. Is that possible?

ghost commented 5 years ago

If this is still occurring please provide the MO2 debug log. if the game is installed on drive C in the user's directory it is possible that access-issues from windows is preventing the scripted edits. Otherwise we should be able to close this within 20 days if no new information.

Syer10 commented 5 years ago

Decided to test since I have a TTW instance. It still happens on the latest MO2 beta(2.2.2alpha5). This seems to only happen on my empty profile. Its probably because the file doesn't exist on my empty profile, so it installs it and tries to edit it, instead of editing the one already there.

Game Directory = D:\Games\SteamLibrary\steamapps\common\Fallout New Vegas MO2 Directory = D:\Game Related\Mod Organizer 2 TTW Instance Directory = D:\Game Related\Tale of Two Wastelands\Mod Orginizer 2

I will attach my debug mo_interface.log mo_interface.log

Holt59 commented 4 years ago

This should be fixed in the next MO2 release with the "built-in" installer for FOMOD C# archive.

This PR fixes the actual problem when installers try to edit files that have been extracted or generated https://github.com/ModOrganizer2/modorganizer-installer_fomod_csharp/pull/1