ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.23k stars 163 forks source link

No game data on top level (minor issue) #618

Closed totyaxy closed 5 years ago

totyaxy commented 5 years ago

The problem

If I install a mod, and I click to manual button, I got unnecessary messages (No game data on top level) if the top directory in mod (archive) is "Data" or "data". But this is perfect directory mod structure. Automatic install works without any unnecessary messages.

This is only minor issue.

Environment

Details

No other info needed. Example mod:

https://www.nexusmods.com/newvegas/mods/35998?tab=files

(here: see top: main files)

LostDragonist commented 5 years ago

Clicking manual means you want MO2 to not perform any automatic actions regarding the archive. You get the raw archive however the mod author decided to package it. Putting files in data/data is not a valid installation therefore MO2 warns you about it.

Are there any considerations I'm missing here? This sounds like expected behavior.

totyaxy commented 5 years ago

Hi!

I know, but the mod top directory data/Data is perfect in the Fallout New Vegas, because this is the REAL top level of any mod in this game. For example, in the Morrowind, this is the Data Files directory. These perfect directories... this is my probem, these VALID directories.

Wolfer4004 commented 5 years ago

I don't think you understand what it's telling you. It is saying that the mod author didn't package the archive correctly. Right click on the "top level", select "set data directory". You should see "looks good" at the bottom. Click ok. Why are you installing manually?

On Mon, Jan 7, 2019, 6:57 PM Róbert M. <notifications@github.com wrote:

Hi!

I know, but the mod top directory data/Data is perfect in the Fallout New Vegas, because this is the REAL top level of any mod in this game. For example, in the Morrowind, this is the Data Files directory. These perfect directories... this is my probem, these VALID directories.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ModOrganizer2/modorganizer/issues/618#issuecomment-452125360, or mute the thread https://github.com/notifications/unsubscribe-auth/AhTz8lveh58k7TenH2qMneOKhDdr5Oclks5vA97QgaJpZM4Z0cOq .

LostDragonist commented 5 years ago

Hi!

I know, but the mod top directory data/Data is perfect in the Fallout New Vegas, because this is the REAL top level of any mod in this game. For example, in the Morrowind, this is the Data Files directory. These perfect directories... this is my probem, these VALID directories.

Is there a reason you're clicking manual in the first place?

Zarggg commented 5 years ago

When you "manually" install a mod archive in MO2, the contents of the archive are assumed to be placed within the existing "Data" directory (when the virtual file system kicks in).

The archive you listed would create a nested "Data" directory inside the existing "Data" directory, which is incorrect behavior. That is what the message is warning you about.

totyaxy commented 5 years ago

Hi!

Thanks for the answers!

Unfortunately, as I can see, this conversation is totally pointless. Because the first question is, what was first, the mods, or this modmanager? The MO2 decided what is the truth, and say it: many(!!!) mod packaged incorrectly?

For example, in FalloutNV, all mod stored in the Data directory. So, an example mod archive looks like it:

Data\example.esp

and the mod install instruction this:

"unpack archive to the game (root) directory", then the result is perfect!

So, if the structure is perfect, very bad answer from MO: "No game data on top level". LOL. Luckily, automatic mode works.

But as I said, this conversation as I said is totally pointless, so this is the end of this conversation, I'm sorry. But one more thing, few people asking me here:

"Why are you installing manually?"

The answer, first, I looked the tutorial, and I like it the step by step possibility (I'm an advanced user/programmer). Second, I want to see step by step, what happens under mod install, what files copied, I want to see the directory structure before mod install.

I suggest, and this doesn't change your interesting "I'm the truth" logic, put a new checkbox to the options: Automatic data directory top level "correction" (lol) under manual install. :)

Have a nice day!

qudix commented 5 years ago

I think what totyaxy is trying to say is that when installing manually, if an archive contains no other folder other than a Data folder, to automatically set it as Data.

To totyaxy: You seem to have mis-interpreted what they've been trying to tell you. There are too many mod-package "standards" to account for. Not every author packages their mod correctly. Having an option would be fine, just don't take what amounts to user choice as "I'm the truth logic".

Zarggg commented 5 years ago

I think what totyaxy is trying to say is that when installing manually, if an archive contains no other folder other than a Data folder, to automatically set it as Data.

That is exactly what MO2 would do when installing a mod such as this one "automatically." Manual installation means you want to pick and choose individual files from the archive yourself. By inference, you should be aware of mod packaging and installation conventions when you do this.

I understand what he's asking for; however, the overall community consensus disagrees with his assertions.

Al12rs commented 5 years ago

@totyaxy The "No game data on top level" notice is not there to tell you whether the mod is packaged correctly or not. The whole point of the manual mode is to remove all automation from the process, showing you how the package is and allowing you to decide what is correct or not.

When MO2 installs mods, it treats the mod folder as the "Data" folder, so under that level you should have stuff like Textures and Meshes folder, not another Data folder if you want to install the mod correctly. When letting MO2 install the mod automatically it detects the data folder inside the archive, looks inside and sees that there are valid files in there so it uses that data folder as the base folder for installation. If you select manual, Mo2 does not do anything to the archive and just shows you the contents of it so you can tell it what is the correct data folder so it can install the mod correctly. So it telling you the current top level is not good is correct.

All good?