ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.23k stars 163 forks source link

Upgrade Nexus mod update check to new API #637

Closed Al12rs closed 5 years ago

Al12rs commented 5 years ago

Task: Implement checking if a mod file received a direct update. If that is not the case but the mod has a new overall version check if the file was moved to Old files or Deleted, in that case we can safely assume there is an update for that file.

There are other cases and states to analyze depending on the capability of the new api.

Silarn commented 5 years ago

This is currently implemented where it should locate any existing indicated file updates and find the latest version of that file. If it's unable to match a file update, then we pull the current mod version. It currently isn't paying attetion to the Old/Deleted category because the existing UI simply wasn't built to indicate an upgrade that way. However, it should be possible to add a new attribute where we can populate the nexus mod category and include this in the version display somehow. We would probably also need to update the filter criteria so it recognizes this as being an 'update'.

atrHusK commented 5 years ago

I've been using stable and have since updated to the latest 2.2.0-beta8 using nexus api and the following issue exists in both versions, I think however this issue (the one I'm replying to) is linked to how you would want to fix it. The problem: While modding Morrowind I've noticed more than a few mod authors forget to have their mod page version updated with their new main mod version. So it has a lower version number than the main file (or other files at that). See for example https://www.nexusmods.com/morrowind/mods/45972

If you download+install from such a mod page then Mod Organizer keeps thinking an update is available, it installs the file with the correct version number for the file itself, but the update check apparently does not check the file version but only the mod page version, which is usually lower.

If this is difficult to implement, then perhaps you can add an alternative mechanism that just checks if the mod page was modified since the last ignore of an mod update.