search

ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.23k stars 163 forks source link

Slow vanilla Morrowind startup time #666

Closed Al12rs closed 5 years ago

Al12rs commented 5 years ago

Investigate slow loading time for vanilla Morrowing through Mo2.

Comparing logs of Project (no issue) and a Daichi (with the issue) there is a 200k call count difference, that can be traced back to a directory crawl for the temp folder that happens only for the user. (MW does like 100K FinfFirstFile)

Need to test ripping out the temp code completely as it could be that whatever issue it was avoiding is now either fixed (or it would be really nice to just fix it with no trickery)

Daichi logs and conversation: https://discordapp.com/channels/265929299490635777/403979692501106688/549336470876323915

Al12rs commented 5 years ago

Was caused by temp guard code, which was a workaround for WB issues. I removed the workaround as it's better to see what the actual issue is. Performance was reported to be several times faster. Apparently Morrowind spams FindFirstFile so this commit made it much faster: https://github.com/ModOrganizer2/usvfs/commit/6543cc8d67fa61cac78650c1c2d0ba5da3dd63db