ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.13k stars 158 forks source link

ModOrganizer 2 crash due to running out of Memory after closing Fallout 4. #80

Closed AikoTM closed 6 years ago

AikoTM commented 7 years ago

Everytime i close Fallout 4. No matter how.. even when it crashes - MO2 crashes aswell telling me it ran out of memory.

I have 16 GB of RAM which are perfectly fine. Search-function didnt yield any results when searching for the term 'memory'. So here i am. Anybody know whats wrong?

krisser143 commented 7 years ago

It's a normal bug. Once the application you are using through Mod Organizer reaches a specific memory threshold (requires you to at least load a game), will cause MO to have a lot of issues, including your error. I think it's some memory management in MO that goes wrong, which possibly is a bug in usvfs. This memory threshold possibly glitches out usvfs and breaks it.

These issues are possible dupes by the way, they are some of the exceptions that occurs when MO handles a program that reaches a specific memory threshold: https://github.com/LePresidente/modorganizer/issues/50 and https://github.com/LePresidente/modorganizer/issues/45

AikoTM commented 7 years ago

Yeah i got #50 and #45 aswell sometimes when MO2 crashes after i close FO4. Mind you i can still scroll through the Mod and Plugin list but as soon as i click on anything... crash.

krisser143 commented 7 years ago

Exactly, MO becomes extremely fragile and unstable when you reach that ram threshold.

LePresidente commented 7 years ago

Will try look at this in the near future though time restraints my side are keeping me off this.

daliborfilus commented 7 years ago

I just found out the hard way that if you run into this (after 2 hours of playing Fallout 4), the game itself will start acting up (e.g. loading screens will say "LOOKUP FAILED!", using Load from menu will not find any saves) and then when you exit, MO2 crashes.

Now my (survival) EXITSAVE didn't save when this happened. This is kinda serious :( I wish I could help you debug this, but I'm more of a Ruby/Go/Java/Kotlin dev. Building stuff for windows and hooking up to processes isn't my thing :/

What was the last MO2 version which didn't have this issue but still somehow works with Fallout 4? 2.0.8.1? or 2.0.8.0? Tried to find this info somewhere but I couldn't...

EDIT: tried playing with 2.0.8.1 (from github releases "Beta 4.1") for about 2 hours and everything did work so far. And I didn't get memory exception after exiting the game.

EDIT2: yep, 2.0.8.1 seem stable in this regard, even after many hours of playing.

The order of things with all my testing with 2.8.0.3 is like this:

With 2.8.0.1:

:-D

dragonshardz commented 7 years ago

Confirming that this issue is not present at all in 2.0.8.1. 2.0.8.2 and x.3 both exhibit this behavior, with .3 being measurably worse than x.2

I suppose the question then is which of the 26 changes between x.1 and x.2 introduced the bug.

krisser143 commented 7 years ago

This is most likely a bug in the vfs. Or it might be a bug in MO's use of said vfs. Both repos should have their commits checked because they are both equally a potential source of the problem.

dacioromero commented 7 years ago

I've had a similar issue after playing for a while as well. Here are some screenshots of the popups after it crashed if it helps.

Silarn commented 6 years ago

Long-standing memory crashes. Fixed on latest builds.

dragonshardz commented 6 years ago

What latest builds? Where? There hasn't been a commit to this repo in nearly a year and your MO forks are solely manual builds which I guarantee you people have no clue how to use.

Silarn commented 6 years ago

My forks are working branches which will be and have been merged here. All development builds are available on the Discord server linked on the main repo description.

Silarn commented 6 years ago

Just FYI https://github.com/LePresidente/modorganizer/tree/QT5.7 is the current working branch. At some point maybe @LePresidente will update master. But the refactor may be finished before then.