search

Modalities / modalities

A framework for training multimodal foundation models.
MIT License
38 stars 3 forks source link

fix: #97 Unused attributes in a component's config yaml are just ignored by Pydantic #134

Closed lllAlexanderlll closed 1 month ago

lllAlexanderlll commented 1 month ago

Implemented verification that all required attributes are set and not more than optional + required attributes are present. The does not use Pydantics verification methods, but implements the check in native python. This allows for a very clear error message about the configuration.

With this fix, the misconfigured config

batch_progress_subscriber:
  component_key: progress_subscriber
  variant_key: rich

was fixed.

le1nux commented 1 month ago

@lllAlexanderlll any updates? :-)

mali-git commented 1 month ago

@lllAlexanderlll any updates? :-)

Please see 73f73b1f5d99965ef13f472ce8f1fba3460edc65 :)