search

Modalities / modalities

A framework for training multimodal foundation models.
MIT License
57 stars 5 forks source link

Refactor the way we log the config and number of parameters #183

Open le1nux opened 2 months ago

le1nux commented 2 months ago

Feature request

In PR #169, we introduced consume_dict for MessageSubscriberIF to log the number of parameters of a model. This method does not integrate yet with the message broker and instead we call this function directly within Main.

https://github.com/Modalities/modalities/blob/b88df85984266329d0897b38177717ec72be0426/src/modalities/logging_broker/subscriber.py#L9-L17

https://github.com/Modalities/modalities/blob/b88df85984266329d0897b38177717ec72be0426/src/modalities/__main__.py#L259

We should rethink the design and integrate it better.

Motivation

Better code design.