In modalities.src.modalities.checkpointing.checkpoint_conversion:
@le1nux proposed solution to #71 :
With self.config_dict["model"]["config"], we pass in config structure logic which we shouldn't do on this level.
My suggestion would be to adapt the ComponentFactory, that is not only instantiates the components but can also instantiate and return a config. This way, we would get rid of the config logic in here.
I think we should add two issues, one for the hardcoded config and one for the proposed fix and link both :-)
In
modalities.src.modalities.checkpointing.checkpoint_conversion:@le1nux proposed solution to #71 : With self.config_dict["model"]["config"], we pass in config structure logic which we shouldn't do on this level.
My suggestion would be to adapt the ComponentFactory, that is not only instantiates the components but can also instantiate and return a config. This way, we would get rid of the config logic in here.
I think we should add two issues, one for the hardcoded config and one for the proposed fix and link both :-)