Modbder / EssentialCraft3

The update of EC2 for newer version of MC
18 stars 16 forks source link

Recursion in WorldGenElementalDrops.java needs optimization. #4

Closed ikkonoishi closed 9 years ago

ikkonoishi commented 9 years ago

You should change most of those functions to static so you aren't throwing hundreds of instances of the class on the stack.

I mean look at this crashlog. http://pastebin.com/DZFQAawK

The stacktrace is nearly a thousand lines long. Not only is line 80 creating new instances of the class, but line 58 is generating additional chunks when it scans outside of the generated area.

It would save you a lot of work to just import CofhLib to handle ore generation.