Modbder / ThaumicBases

An addon for ThaumCraft 4(made by Azanor), which adds a lot of random things.
Creative Commons Zero v1.0 Universal
14 stars 34 forks source link

[1.7.10] MFR cannot properly detect Plax as a crop for Harvesters #17

Closed Shadows-of-Fire closed 6 years ago

Shadows-of-Fire commented 8 years ago

According to previous sources, this is usually an error on the side of the crop, where it is not properly defined as a plant or something of the sort. Waila also does not show growth %.

Modbder commented 8 years ago

That happens since TB's crops extend the BlockBush rather than BlockCrops. I still return EnumPlantType.Crop with a getPlantType method, but I guess that is not a thing MFR checks for. I can implement a WAILA fix/plugin in order to make it show growth %, but I do not know about MFR - does it have an API for that sort of things?

Modbder commented 8 years ago

I've checked MFR's github and indeed, they do have an API for that. When 1.8 version of MFR's API will be released I will make sure to add those interfaces to my plants to make them compatible with MFR(assuming the issue will still be existing at that point). I will leave this issue open, but if you want - feel free to close it

Shadows-of-Fire commented 8 years ago

As far as I know MFR and the other CoFH mods currently have no plans to hit 1.8, so if you had the free time could you implement that into the 1.7 version?

Shadows-of-Fire commented 6 years ago

rip 1.7