SPI pins of esp32/Subplatform was changed

Moddable-OpenSource / moddable

Tools for developers to create truly open IoT products using standard JavaScript on low cost microcontrollers.

http://www.moddable.com

1.32k stars 236 forks source link

SPI pins of esp32/Subplatform was changed #713

Closed stc1988 closed 2 years ago

stc1988 commented 2 years ago

About https://github.com/Moddable-OpenSource/moddable/commit/93e6a19ba90559bff3f6f30dc45d9d3b079d60e1 ; This is SPI pins of mc.defines.h in esp32/m5stack

#define MODDEF_SPI_MOSI_PIN (13)
#define MODDEF_SPI_MISO_PIN (12)
#define MODDEF_SPI_SCK_PIN (14)

It's different from manifest.json of m5stack . I think defines of esp32 overwrites which subplatform defined.

phoddie commented 2 years ago

Good catch! I accidentally broke that when implementing support for pin configuration to the Ecma-419 SPI implementation. We've already got a fix tested and will push that today.

phoddie commented 2 years ago

The changes are committed.

stc1988 commented 2 years ago

I confirmed this issue fixed.