search

ModdingX / ModGradle

ModGradle adds some gradle plugins useful for creating forge mods.
Apache License 2.0
3 stars 0 forks source link

Forge Gradle hangs when using Sugarcane Mappings #14

Closed Rover656 closed 1 year ago

Rover656 commented 2 years ago

Whenever sugarcane mappings are used, Ender IO's builds stall infinitely until they are stopped and re-run, this breaks GitHub Actions. I'm providing 2 build logs from Actions to show you where this fails.

Using parchment: https://github.com/SleepyTrousers/EnderIO-Rewrite/runs/7889663799 Using sugarcane: https://github.com/SleepyTrousers/EnderIO-Rewrite/runs/7889774021

Happy to provide any more information if required :)

noeppi-noeppi commented 2 years ago

See https://github.com/MinecraftForge/ForgeGradle/issues/886

noeppi-noeppi commented 2 years ago

The reason, why the deadlock does not occur with parchment in most cases is that librarian only uses MavenArtifactDownloader very early in the method that resolves the mappings.

For downloading the actual mappings zip file, it has some custom logic that is used to support snapshots. However as SugarCane has no snapshots, it just uses MavenArtifactDownloader (which is also the fallback option in librarian).

noeppi-noeppi commented 1 year ago

Fixed in ForgeGradle