search

ModdingX / ModGradle

ModGradle adds some gradle plugins useful for creating forge mods.
Apache License 2.0
3 stars 0 forks source link

make pack method in CurseDep easier #4

Closed MelanX closed 2 years ago

noeppi-noeppi commented 2 years ago

What is the purpose here? This can be really confusing and I don't think the two characters saved between

curse.pack(projectId, fileId, [ explude1, exclude2, exclude3 ])

and

curse.pack(projectId, fileId, explude1, exclude2, exclude3)

is worth making it so it's no longer clear that all the arguments except the first two belong together and form excludes.

If have a different opinion on that let me know but I don't see a real advantage in this.

MelanX commented 2 years ago

Using [ exclude1, exclude2 ] was too easy, didn't think about it.