ModelDBRepository / 2017405

Parkinsonian Motor Network Model during Multivariable Closed-loop DBS (Fleming et al 2023)
https://modeldb.science/2017405
0 stars 0 forks source link

Model breaks NEURON CI #1

Open JCGoran opened 1 month ago

JCGoran commented 1 month ago

I am getting this error when trying to run the model (also present in the CI, see for instance this run):

Error: new_seed used as both variable and function in file Gfluct.mod

We need to pick which one we want, the variable:

https://github.com/ModelDBRepository/2017405/blob/601ca5c62793af858d32f235219323ca33ad5957/Gfluct.mod#L119

or the function:

https://github.com/ModelDBRepository/2017405/blob/601ca5c62793af858d32f235219323ca33ad5957/Gfluct.mod#L197

Considering neither the variable nor the function are used anywhere, I suggest we remove them, or at the very least rename one of them.

ramcdougal commented 1 month ago

This is a very old file. The issue has to do with the NEURON 9.x changes. The solution for ModelDB:8115's version was to remove the RANGE.

My only hesitation is that there are commented out lines in [Depressing_Spinal_Motoneuron_Cell_Classes.py](https://github.com/ModelDBRepository/2017405/blob/601ca5c62793af858d32f235219323ca33ad5957/Depressing_Spinal_Motoneuron_Cell_Classes.py#L248) that attempted to use the RANGE variable. I'm unclear if the d1_r, d2_r etc strategies have any effect on the MOD files. @nrnhines do they?

nrnhines commented 1 month ago

I'd choose the PROCEDURE. The RANGE has no definition in the mod file and it is a good thing that an error is generated by the translator.

In 8.2, nowhere in the translated mod file is new_seed anything but a function. When I launch, consider the hoc code

create soma
objref gf
gf = new Gfluct(.5)
gf.newseed

will produce

nrniv: GFluct is not a template
 near line 7
 gf = new GFluct(.5)

So the commented out lines, when uncommented, don't work.