ModelDriven / Alf-Reference-Implementation

Open-source implementation of the Action Language for fUML (Alf) specification.
30 stars 2 forks source link

Fix a signal-send invocation of a specialized signal #51

Closed seidewitz closed 6 years ago

seidewitz commented 6 years ago

A signal send to a signal that specializes another signal causes an exception during mapping, if the specialized signal inherits attributes.

seidewitz commented 6 years ago

There is a "TODO: Use getAllAttributes(signal), once this is supportable by fUML." in ActivityGraph.addSendSignalAction. Not using getAllAttributes means only owned attributes are reflected in the pins on a send signal action, even though the constraint checking considers the inherited attributes of a signal when validating the arguments to a signal send. The problem is that standard fUML currently only supports setting the owned attributes of a signal when it is sent, which makes allowing signal attribute inheritence rather pointless, even though allowed in fUML.

seidewitz commented 6 years ago

Fixed in v1.1.0a.