ModelDriven / Alf-Reference-Implementation

Open-source implementation of the Action Language for fUML (Alf) specification.
30 stars 2 forks source link

ExternalElementReferenceImpl.hasReceptionFor can throw a NullPointerException #71

Closed seidewitz closed 5 years ago

seidewitz commented 5 years ago

The test ((Reception)member).getSignal().equals(umlSignal) in ExternalElementReferenceImpl.hasReceptionFor will through a NullPointException if getSignal returns null. Any reception is required by the UML abstract syntax to have a reference to a signal, but some tools may allow this to be null in partial or ill-formed models. The code should be robust against such cases and not through an exception.

seidewitz commented 5 years ago

There is also a possible NPE in ExternalNamespaceImpl.getNewReference if the reference parameter is null.

seidewitz commented 5 years ago

Resolved in v1.1.0f.