The mapOperator method has operand1Result and operand2Result arguments. In BinaryExpressionMapping, this method checks if these arguments are null, and throws a MappingError if either one is. The method is overridden in EqualityExpressionMapping, without ever calling the superclass method. However, EqualityExpressionMapping.mapOperator does not check whether the operand result arguments are null. If one is, due to an ill-formed model, this ultimately causes a NullPointerException rather than a more controlled MappingError. The method in EqualityExpressionMapping should, instead, check for null arguments, as the superclass method does.
seidewitz
commented
5 years ago
The
mapOperatormethod hasoperand1Resultandoperand2Resultarguments. InBinaryExpressionMapping, this method checks if these arguments are null, and throws aMappingErrorif either one is. The method is overridden inEqualityExpressionMapping, without ever calling the superclass method. However,EqualityExpressionMapping.mapOperatordoes not check whether the operand result arguments are null. If one is, due to an ill-formed model, this ultimately causes aNullPointerExceptionrather than a more controlledMappingError. The method inEqualityExpressionMappingshould, instead, check for null arguments, as the superclass method does.