ModelDriven / Alf-Reference-Implementation

Open-source implementation of the Action Language for fUML (Alf) specification.
30 stars 2 forks source link

Illegal data value update checks should not be done in other validation checks #96

Closed seidewitz closed 3 years ago

seidewitz commented 3 years ago

The constraint checking methods NameLeftHandSideImpl.nameLeftHandSideTargetAssignment and FeatureLeftHandSideImpl.featureLeftHandSideFeatureExpression include additional checks (over what is called for in the Alf 1.1 specification) that, if the left-hand side is for a feature whose target type is a data type, then the LHS is a legal data value update. However, this is confusing, because the error messages are for different errors. In particular, featureLeftHandSideFeatureExpression is reported as "Target expression must have a multiplicity upper bound of 1", which doesn't make any sense if the real problem is an illegal data value update.

seidewitz commented 3 years ago

Fixed in v1.1.0j.