An antiquated feature that visualized invariants in a small graph was previously disabled, but most of the relevant code was left behind. This visualization is unlikely to significantly benefit future Perfume features, and the leftover, dead code unnecessarily complicates the codebase.
The dead code associated with the invariant visualization feature should be removed from the repo.
[Issue created by stanleyrya: 2015-02-03]
[Last updated on bitbucket: 2015-02-09]
[Comment created by ohmann: 2015-02-09]
Closing issue 61
→ <>
[Comment created by stanleyrya: 2015-02-04]
Solution in revision e97b484e2aae, please review.
[Comment created by stanleyrya: 2015-02-09]
Solution in revision e751c7903b7e, please review.
[Comment created by ohmann: 2015-02-03]
It turns out this div is unnecessary and can be removed.
[Comment created by ohmann: 2015-02-07]
I removed one block that you commented out. You can assume code is safe to fully remove if a full search of the repo reveals that the code isn't used anywhere (not even in commented-out code).
As we stumble on more dead code... There are a few other js libraries that are no longer being used: bootstrap and joint js. You can remove these as well as the old js file for generating the model: fsa.js. Bootstrap (or something related like jqueryui) may be something you wish you re-add later, but that's easy to do when the time comes and we have a known, immediate use for them.
[Comment created by stanleyrya: 2015-02-06]
Solution in revision 06be94d87e64, please review.
An antiquated feature that visualized invariants in a small graph was previously disabled, but most of the relevant code was left behind. This visualization is unlikely to significantly benefit future Perfume features, and the leftover, dead code unnecessarily complicates the codebase.
The dead code associated with the invariant visualization feature should be removed from the repo.
[Issue created by stanleyrya: 2015-02-03] [Last updated on bitbucket: 2015-02-09]
[Comment created by ohmann: 2015-02-09] Closing issue 61
→ <>
[Comment created by stanleyrya: 2015-02-04] Solution in revision e97b484e2aae, please review.
[Comment created by stanleyrya: 2015-02-09] Solution in revision e751c7903b7e, please review.
[Comment created by ohmann: 2015-02-03] It turns out this div is unnecessary and can be removed.
[Comment created by ohmann: 2015-02-07] I removed one block that you commented out. You can assume code is safe to fully remove if a full search of the repo reveals that the code isn't used anywhere (not even in commented-out code).
As we stumble on more dead code... There are a few other js libraries that are no longer being used: bootstrap and joint js. You can remove these as well as the old js file for generating the model: fsa.js. Bootstrap (or something related like jqueryui) may be something you wish you re-add later, but that's easy to do when the time comes and we have a known, immediate use for them.
[Comment created by stanleyrya: 2015-02-06] Solution in revision 06be94d87e64, please review.