Begin developing dual-pane view. Must be modular to allow for more panes in the future if ever desired. To start, user interface will simply be appended an extra button titled "Model/Invariants". This button will create two separate panes: one for the model and one for invariants.
[Issue created by stanleyrya: 2015-03-26]
[Last updated on bitbucket: 2015-10-21]
[Comment created by ohmann: 2015-10-21]
Resolved in c386cd6f3c2f and merged into default in 0775aaa5fe10.
[Comment created by stanleyrya: 2015-10-20]
Changesets: f592bc59b470, 58b455d89688, 10d10b843617, c386cd6f3c2f
Ready to try another CR. Kept changes to bug-fixing and code clarity.
Hopefully we can merge to Default now :)
[Comment created by stanleyrya: 2015-10-20]
Sorry about the lack of branching. My laziness got the best of me.
I agree it can get confusing when you don't know there are three panes. I'll play around with it a bit.
Log highlighting works by clicking the edge in the model. Right now the model's edges are fairly small so you may need to zoom in.
I'm a huge fan of self-documenting code that don't need comments to be understood. That being said, I don't think this code is necessarily self-documenting. I'll go through the code base in the next few days and add comments for clarity where I can.
form.js:
Currently the only way to highlight a line is to first get the text located on that line and then highlight any text that matches it. This is why I included a clear function, as the text in the input box may not be relevant anymore after someone has edited it. That said, we could change it so only line highlighting is cleared upon a change, and pehaps make it unusable until the model is regenerated.
index_template.html:
The hg version indicator wasn't removed, but it was hidden under the multiple-panes by accident. Should be displayed now.
[Comment created by ohmann: 2015-10-20]
@stanleyrya: Code review as of revision 47d915d6acf4:
General comments:
There should be some kind of light bordering around the different panes, as users could easily be confused as it is now and not understand the separation
Other new features (like highlighting log lines that correspond to model edges) would have been better in their own issue branches for better organization. Don't worry about changing it this time, but update this issue to describe this new enhancement/feature as well
Speaking of new features, how does the log line highlighting work? Or is it not pushed/done yet?
Add documentation (comments) to the functions / lines you change or add (especially in large chunks of code like multipanel.js and traverseData.js). You did this a little, but more would be better
custom.css:
Is the commented-out styling going to become necessary at some point? If not, remove it
form.js:
I'm not sure about clearing everything if the user edits any input text box. If they're just toying with the log but don't try to re-infer the model, I don't think we should forcibly clear the other tabs
fsa2.js:
On line 72, say resources, as not all resources are timestamps
index_template.html:
On line 7 and 44, I'd just remove these comments. We don't need to warn readers about every cheetah templating line, and the comments stick around after the templating finishes, which is odd.
You removed the hg version indicator; we want this to stay. You can move it to the header (e.g., all the way on the right), but don't remove it entirely.
Begin developing dual-pane view. Must be modular to allow for more panes in the future if ever desired. To start, user interface will simply be appended an extra button titled "Model/Invariants". This button will create two separate panes: one for the model and one for invariants.
[Issue created by stanleyrya: 2015-03-26] [Last updated on bitbucket: 2015-10-21]
[Comment created by ohmann: 2015-10-21] Resolved in c386cd6f3c2f and merged into default in 0775aaa5fe10.
[Comment created by stanleyrya: 2015-10-20] Changesets: f592bc59b470, 58b455d89688, 10d10b843617, c386cd6f3c2f
Ready to try another CR. Kept changes to bug-fixing and code clarity.
Hopefully we can merge to Default now :)
[Comment created by stanleyrya: 2015-10-20]
form.js:
index_template.html:
[Comment created by ohmann: 2015-10-20] @stanleyrya: Code review as of revision 47d915d6acf4:
General comments:
custom.css:
form.js:
fsa2.js:
index_template.html: