ModelInference / perfume-frontend

Web-based frontend for Perfume tool
Other
1 stars 0 forks source link

Should not be able to click on edges from the INITIAL node #70

Closed bestchai closed 4 years ago

bestchai commented 4 years ago

Clicking on edges emitted by the INITIAL node changes the color of the edge. This should not happen since the edge does not correspond to any log lines.

[Issue created by bestchai: 2015-11-16] [Last updated on bitbucket: 2015-12-15]

[Comment created by ohmann: 2015-12-15] Merged in: 5f24c14f6c92

[Comment created by stanleyrya: 2015-12-15] All set!

922dfc5f26d0

[Comment created by stanleyrya: 2015-12-15] That sounds good to me!

[Comment created by ohmann: 2015-12-10] Looks pretty good, but I'd suggest we un-highlight any currently highlighted edge/node/lines if initial or terminal edges/nodes are clicked. Based on your code, it should be fairly easy to make that change, right? This will be less important when issue #97 is resolved, but it still seems like the most sensible thing to do when one of these eventless edges or nodes is clicked.

[Comment created by stanleyrya: 2015-12-09] @ohmann:

Fixed. I am a little concerned with how I fixed it though, as it now does not rehighlight if there are no log lines to highlight. This shouldn't be an issue since this case only happens for the initial node, initial edges, and terminal node.

f0e95fca8f8d