Add the missing interrupted-by invariants. They are currently being sent to the front-end but not displayed.
[Issue created by stanleyrya: 2015-12-09]
[Last updated on bitbucket: 2015-12-15]
[Comment created by bestchai: 2015-12-14]
A bit late with my comment, but I like this choice. +1
[Comment created by ohmann: 2015-12-15]
Merged in: e55e6f96b5fd
[Comment created by ohmann: 2015-12-14]
Agreed. Ryan, change the page to use that symbol.
[Comment created by brunyuriy: 2015-12-14]
Let's go with the 4th one: ⇻
[Comment created by stanleyrya: 2015-12-15]
dacd33431748
[Comment created by ohmann: 2015-12-15]
I think we want to show headers for empty sections because that clearly shows that we mine that invariant type but that there are no instances of it for the given log. If this is different than the current behavior, let's make a new issue for this.
Edit: what Yuriy suggested is the best option IMO.
[Comment created by stanleyrya: 2015-12-15]
Fixed!
2f68a191ee47
Do we want to make it so it does not display the interrupted-by invariants section if none were inferred? (the same goes for the other types of invariants)
[Comment created by brunyuriy: 2015-12-15]
No. Can we put the word "none" where the invariants would go?
[Comment created by ohmann: 2015-12-09]
@bestchai and @stanleyrya, vote away.
[Comment created by brunyuriy: 2015-12-09]
Oy, i just realized that in my prior comment, bitbucket renumbered the choices. My actual choices were 4 and maybe 12 (which is not visible, I guess). So 4 is winning so far.
[Comment created by brunyuriy: 2015-12-09]
My top choices are:
⇻
or maybe
⤯
[Comment created by ohmann: 2015-12-09]
I just noticed that in Chrome on my phone, I can only see 1-4 and 7. Let's limit the choices to those so nobody sees boxes instead of our meticulously chosen symbol. :)
Of those, I like 3 and 4 the best.
[Comment created by ohmann: 2015-12-09]
I'm not crazy about the recycle-esque symbol. The second one could work.
Some of my suggestions:
1. ⇢
2. ⇥
3. ⇴
4. ⇻
5. ⌤
6. ⍆
7. ➠
8. ⟛
9. ⟴
10. ⤏
11. ⭬
12. ⤯
13. ⦵
14. ⩥
15. ⪫
16. ⭲
17. ⭼
[Comment created by brunyuriy: 2015-12-09]
We need a unique arrow type for this. Maybe something like this:
Tony, Ivan, what do you think? I had a harder time finding some sort of arrow type that's an "interruption". Maybe something along these lines?
[Comment created by stanleyrya: 2015-12-09]
@ohmann:
Everything is all set here, however I did not know how you wanted it to be displayed. Should we use the same icon as 'Never Followed By'? Any suggestions?
Add the missing interrupted-by invariants. They are currently being sent to the front-end but not displayed.
[Issue created by stanleyrya: 2015-12-09] [Last updated on bitbucket: 2015-12-15]
[Comment created by bestchai: 2015-12-14] A bit late with my comment, but I like this choice. +1
[Comment created by ohmann: 2015-12-15] Merged in: e55e6f96b5fd
[Comment created by ohmann: 2015-12-14] Agreed. Ryan, change the page to use that symbol.
[Comment created by brunyuriy: 2015-12-14] Let's go with the 4th one: ⇻
[Comment created by stanleyrya: 2015-12-15] dacd33431748
[Comment created by ohmann: 2015-12-15] I think we want to show headers for empty sections because that clearly shows that we mine that invariant type but that there are no instances of it for the given log. If this is different than the current behavior, let's make a new issue for this.
Edit: what Yuriy suggested is the best option IMO.
[Comment created by stanleyrya: 2015-12-15] Fixed!
2f68a191ee47
Do we want to make it so it does not display the interrupted-by invariants section if none were inferred? (the same goes for the other types of invariants)
[Comment created by brunyuriy: 2015-12-15] No. Can we put the word "none" where the invariants would go?
[Comment created by ohmann: 2015-12-09] @bestchai and @stanleyrya, vote away.
[Comment created by brunyuriy: 2015-12-09] Oy, i just realized that in my prior comment, bitbucket renumbered the choices. My actual choices were 4 and maybe 12 (which is not visible, I guess). So 4 is winning so far.
[Comment created by brunyuriy: 2015-12-09] My top choices are:
⇻ or maybe
⤯
[Comment created by ohmann: 2015-12-09] I just noticed that in Chrome on my phone, I can only see 1-4 and 7. Let's limit the choices to those so nobody sees boxes instead of our meticulously chosen symbol. :)
Of those, I like 3 and 4 the best.
[Comment created by ohmann: 2015-12-09] I'm not crazy about the recycle-esque symbol. The second one could work.
Some of my suggestions:
1. ⇢
2. ⇥
3. ⇴
4. ⇻
5. ⌤
6. ⍆
7. ➠
8. ⟛
9. ⟴
10. ⤏
11. ⭬
12. ⤯
13. ⦵
14. ⩥
15. ⪫
16. ⭲
17. ⭼
[Comment created by brunyuriy: 2015-12-09] We need a unique arrow type for this. Maybe something like this:
Tony, Ivan, what do you think? I had a harder time finding some sort of arrow type that's an "interruption". Maybe something along these lines?
[Comment created by stanleyrya: 2015-12-09] @ohmann:
Everything is all set here, however I did not know how you wanted it to be displayed. Should we use the same icon as 'Never Followed By'? Any suggestions?
f5403a4c3f9f