observe that yellow highlighting lines are not removed, the model is not cleared, the invariants are not cleared, the arguments are not cleared. All of these should be cleared.
[Issue created by bestchai: 2015-11-16]
[Last updated on bitbucket: 2016-01-28]
[Comment created by ohmann: 2016-01-28]
Looks good.
Merged in: f914597ff048
[Comment created by stanleyrya: 2016-01-28]
Forgot to include changeset: 79d163dbbd1f
[Comment created by stanleyrya: 2016-01-28]
@ohmann I was able to refactor the graph rendering code, however I realized that my clear function had a bug in the process. It turns out that the way it was written prevented any edits to the text fields to be made at all. I was able to fix it by changing the behavior a little bit: if a developer starts writing into one of the text fields while there is already a model, everything except for the input boxes is cleared. What do you think?
[Comment created by ohmann: 2015-12-15]
In fsa2.js, lines 268-276 are repeated in the new clearModel() function. Replace them with a call to clearModel(), and add a parameter to clearModel() that allows specifying whether the zoom (lines 270-274) should happen. Or, if those lines don't have any negative effect when clearing the model with the clear button, just move the zoom code to clearModel() directly and make the call at line 268.
[Comment created by stanleyrya: 2015-12-15]
Fixed!
click on an edge
see highlighted log lines
press clear
observe that yellow highlighting lines are not removed, the model is not cleared, the invariants are not cleared, the arguments are not cleared. All of these should be cleared.
[Issue created by bestchai: 2015-11-16] [Last updated on bitbucket: 2016-01-28]
[Comment created by ohmann: 2016-01-28] Looks good.
Merged in: f914597ff048
[Comment created by stanleyrya: 2016-01-28] Forgot to include changeset: 79d163dbbd1f
[Comment created by stanleyrya: 2016-01-28] @ohmann I was able to refactor the graph rendering code, however I realized that my clear function had a bug in the process. It turns out that the way it was written prevented any edits to the text fields to be made at all. I was able to fix it by changing the behavior a little bit: if a developer starts writing into one of the text fields while there is already a model, everything except for the input boxes is cleared. What do you think?
[Comment created by ohmann: 2015-12-15] In fsa2.js, lines 268-276 are repeated in the new clearModel() function. Replace them with a call to clearModel(), and add a parameter to clearModel() that allows specifying whether the zoom (lines 270-274) should happen. Or, if those lines don't have any negative effect when clearing the model with the clear button, just move the zoom code to clearModel() directly and make the call at line 268.
[Comment created by stanleyrya: 2015-12-15] Fixed!
bb93e72d6d26