ModelInference / perfume-frontend

Web-based frontend for Perfume tool
Other
1 stars 0 forks source link

Remove traces with highlighted log lines fails when every trace is removed #82

Closed bestchai closed 4 years ago

bestchai commented 4 years ago

When the user tries to remove all traces with highlighted log lines and every trace has a highlighted log line Perfume responds with the following error message:

You must enter both a log and regular expressions before Perfume can infer a model.

[Issue created by stanleyrya: 2016-04-07] [Last updated on bitbucket: 2016-04-15]

[Comment created by ohmann: 2016-04-14] I think he means w.r.t. our email thread detailing four options that are orthogonal to which panes are cleared.

[Comment created by brunyuriy: 2016-04-14] Tony's right. Final answer.

[Comment created by wborkofsky: 2016-04-14] Okay, I currently have it so if you remove the last line, it clears the model and invariants pane, let me know when a final decision is made on what to do with this. Thanks.

[Comment created by ohmann: 2016-04-15] @wborkofsky I added issue #114 as a generalized version of your suggestion.

[Comment created by ohmann: 2016-04-15] Merge. Resolved issue 111

→ <<cset 7fbe66965ee6>>

[Comment created by wborkofsky: 2016-04-15] Solution in revision 548568b, please review.

Also, just a side thought. Normally, when you remove all traces with highlighted log lines, it will open the parsing dialog and then show the new model when it is done. However, when you remove all of them, it just clears the model and everything disappears. There is no indication of anything and could seem odd for someone using it as they may just question what happened. I know there has been discussion about what to do with all of this, so this was just something I thought of when testing it so I figured I would share my thoughts.

[Comment created by wborkofsky: 2016-04-14] If you remove a highlighted line, is it supposed to clear the model so it is just blank, or leave what was ever left?

[Comment created by ohmann: 2016-04-14] Ah, good point/question. If we end up clearing the entire log, the model and invariants panes should still be cleared to leave things in a consistent state.

[Comment created by ohmann: 2016-04-12] We probably still want to do what the user requested (remove all lines), but we should detect that all have been removed and not attempt to infer a new model automatically as usual. This will prevent the error message from appearing.