search

ModelOriented / DALEX

moDel Agnostic Language for Exploration and eXplanation
https://dalex.drwhy.ai
GNU General Public License v3.0
1.38k stars 166 forks source link

move ingredients, iBreakDown etc. to Imports and use their print, plot functions #132

Closed hbaniecki closed 4 years ago

pbiecek commented 4 years ago

DALEX cannot import ingredients, because ingredients imports DALEX. cyclic dependencies are not allowed.

will look for other solutions, either keep ingredients and iBreakDown as suggests (-> problem with plot() ) or move shared functions to another package (like color themes to DALEXutils, OMG)

pbiecek commented 4 years ago

ok, candidate solution is in the branch https://github.com/ModelOriented/DALEX/tree/DALEX_1_0_0

it looks like the print/plot functions from ingredients/iBreakDown are available even if these packages are only Suggested.

The library(DALEX) does not load ingredients directly (at leas is not visible via loadedNamespaces()),

But if any function from ingredients is called (e.g. after DALEX::variable_importance) then ingredients are loaded according to loadedNamespaces() and plot/print functions are working properly.

pbiecek commented 4 years ago

fixed in https://github.com/ModelOriented/DALEX/tree/DALEX_1_0_0