Closed pbiecek closed 4 years ago
explain_scikitlearn
arguments in the main vignette could be moved to the top of the paragraph in my opinioncreate_env
could be more accurate in my opiniondata
and precalculate
parameters descriptionfile names
other.R
to helper_functions.R
or anything else http://r-pkgs.had.co.nz/style.htmlonLoad.R
to on_attach.R
too many blank code lines in many files, great example:
add comments
write } else {
explain_h2o
has other permutation of parameters than explain
https://github.com/ModelOriented/DALEXtra/blob/master/R/explain_h2o.R
same : https://github.com/ModelOriented/DALEXtra/blob/master/R/explain_mljar.R
other permutation of parameters in doc and function
other
function_name <- function(x)
looks better in the same line and is consistent
https://github.com/ModelOriented/DALEXtra/blob/master/R/explain_mljar.R#L47
DALEXverse 0.19.8 release summer 2019
Integration
assigned: @pbiecek
Code review
assigned: @hbaniecki
Feature review
assigned: @WojciechKretowicz