ModelOriented / SAFE

Surrogate Assisted Feature Extraction
MIT License
36 stars 9 forks source link

Changing sklearn install requirement #8

Closed jlevy44 closed 5 years ago

jlevy44 commented 5 years ago

Hey there. Great package!

Just wanted to point something out that I've seen across a few packages. The install was fine for me because I already have this install, but I think you should remove sklearn from this in setup.py:

    install_requires=[
          'numpy',
          'ruptures',
          'sklearn',
          'pandas',
          'scipy',
          'kneed'
      ],

and replace it with "scikit-learn".

    install_requires=[
          'numpy',
          'ruptures',
          'scikit-learn',
          'pandas',
          'scipy',
          'kneed'
      ],

It does install the wrong package and could confuse individuals who have not installed scikit learn before because it would not install the real package for them. https://pypi.org/project/sklearn/ mentions not to use that specification as an install.