ModelOriented / auditor

Model verification, validation, and error analysis
https://modeloriented.github.io/auditor/
58 stars 14 forks source link

obsolete example for `plot_prediction` #136

Closed pbiecek closed 5 years ago

pbiecek commented 5 years ago

It looks like the line

plot(mr_lm, type = "prediction", abline = TRUE)

in the example for plot_prediction (see https://modeloriented.github.io/auditor/reference/plot_prediction.html) is obsolete, since the type = "prediction" does nothing.

it would be better to remove this line from examples

hbaniecki commented 5 years ago

What do you mean by "does nothing" ?

plot(mr_lm, abline = TRUE)
plot(mr_lm, type = "prediction", abline = TRUE)

are two different plots

pbiecek commented 5 years ago

Plots in the example are the same, (this is why I was surprised) but now I see that this example is suppose to show that plot(type = "prediction") can be used instead of plot_prediction()

So maybe it is enough to add a comment that these two commands are equivalent.