ModelOriented / forester

Trees are all you need
https://modeloriented.github.io/forester/
GNU General Public License v3.0
112 stars 15 forks source link

Two problems #31

Closed jeam-github closed 2 years ago

jeam-github commented 2 years ago
  1. Running your example from your Medium article I receive the error "Error in make_ranger(data = data_train, target = "overall", type = "regression", : unused argument (label = "Basic Ranger")" and the run ceases.

  2. Running the following causes an error f_model <- forester(data = data_train, target = "overall", type = "regression")


    FORESTER Original shape of train data frame: 3200 rows, 42 columns


    NA values There is no NA values in your data.


    CREATING MODELS --- Ranger model has been created --- Error in library.dynam(lib, package, package.lib) : shared object ‘libcatboostr.so’ not found

Are you able to tell me what I am doing wrong? Many thanks

(System Software Overview: System Version: macOS 11.6 (20G165) Kernel Version: Darwin 20.6.0 Boot Volume: Macintosh HD Boot Mode: Normal)

lhthien09 commented 2 years ago

Hi, thank you for your reviews.

  1. About unused arguments, since the label argument was recently added for each make_...() function, I hope that, after installing the package again, the problem will be tackled.

  2. catboost, since this library has not been yet available in CRAN, so you can follow this issue: installing catboost, and this trick works for MacOS :) : devtools::install_url('https://github.com/catboost/catboost/releases/download/v0.26.1/catboost-R-Darwin-0.26.1.tgz', INSTALL_opts = c("--no-multiarch", "--no-test-load"))

jeam-github commented 2 years ago

Thanks for the reply.

Where is this new version of "forester" - it does not seem to be on CRAN?

On 1/12/2021, at 2:36 AM, lhthien09 @.***> wrote:

Hi, thank you for your reviews.

About unused arguments, since the label argument is recently added for each make_...() function, I hope that, after installing the package again, the problem will be tackled.

catboost, since this library has not been yet available in CRAN, so you can follow this issue: installing catboost https://github.com/ModelOriented/forester/issues/11, and this trick works for MacOS :) : devtools::install_url('https://github.com/catboost/catboost/releases/download/v0.26.1/catboost-R-Darwin-0.26.1.tgz', INSTALL_opts = c("--no-multiarch", "--no-test-load"))

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ModelOriented/forester/issues/31#issuecomment-982642973, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDOYM4DKYCV4HXZ2OXEJELUOTHMHANCNFSM5IFKSOCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lhthien09 commented 2 years ago

Thanks for your interest.

{forester} is still in the development stage, after receiving feedbacks and implementing further functionalities, {forester} will be shortly introduced on CRAN.

lhthien09 commented 2 years ago

Thanks for the reply. Where is this new version of "forester" - it does not seem to be on CRAN? On 1/12/2021, at 2:36 AM, lhthien09 @.***> wrote: Hi, thank you for your reviews. About unused arguments, since the label argument is recently added for each make_...() function, I hope that, after installing the package again, the problem will be tackled. catboost, since this library has not been yet available in CRAN, so you can follow this issue: installing catboost <#11>, and this trick works for MacOS :) : devtools::install_url('https://github.com/catboost/catboost/releases/download/v0.26.1/catboost-R-Darwin-0.26.1.tgz', INSTALL_opts = c("--no-multiarch", "--no-test-load")) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDOYM4DKYCV4HXZ2OXEJELUOTHMHANCNFSM5IFKSOCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

We updated package in Github, so after downloading and installing {forester} again, the package should work now.

jeam-github commented 2 years ago

There is still a problem for me. What am I doing wrong (see below) Jim McIntosh

devtools::install_url('https://github.com/catboost/catboost/releases/download/v0.26.1/catboost-R-Darwin-0.26.1.tgz', INSTALL_opts = c("--no-multiarch", "--no-test-load")) Downloading package from url: https://github.com/catboost/catboost/releases/download/v0.26.1/catboost-R-Darwin-0.26.1.tgz ✔ checking for file ‘/private/var/folders/l2/bhymb90x589g_1y3mvwnx4hr0000gn/T/RtmpUp8hm8/remotes22141688a781/catboost/DESCRIPTION’ (538ms) ─ building ‘catboost_0.26.1.tar.gz’ ding ‘catboost_0.26.1.tar.gz’

  • installing source package ‘catboost’ ... using staged installation R inst byte-compile and prepare package for lazy loading ** help * installing help indices building package indices ** checking absolute paths in shared objects and dynamic libraries
  • DONE (catboost) library(forester) data("titanic", package = 'DALEX') best_model <- forester(data = titanic,
  • target = "survived",
  • type = "classification",
  • metric = "precision",
  • tune = FALSE)

    FORESTER Program coerces factors into numeric values: MECHANISM: no -> 1 and yes -> 0. Original shape of train data frame: 1764 rows, 9 columns


    NA values percentage of NAs in data_train: 0.642479213907785% NA values has been filled.


    CREATING MODELS --- Ranger model has been created --- Parameter 'cat_features' is meaningless because column types are taken from data.frame. Please, convert categorical columns to factors manually. --- Catboost model has been created --- --- Xgboost model has been created --- --- LightGBM model has been created ---


    COMPARISON Error in update_data(m, data_test[, -which(names(data_test) == target)], : could not find function "update_data"

On 13/12/2021, at 10:03 AM, lhthien09 @.***> wrote:

Closed #31 https://github.com/ModelOriented/forester/issues/31.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ModelOriented/forester/issues/31#event-5753291200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDOYM77KU2UKFUWULJQCTTUQUEZTANCNFSM5IFKSOCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.