search

ModelOriented / ingredients

Effects and Importances of Model Ingredients
https://modeloriented.github.io/ingredients/
GNU General Public License v3.0
37 stars 19 forks source link

added title to Partial Dependence profile / Accumulated Dependence profile #97 #104

Closed jakwisn closed 4 years ago

jakwisn commented 4 years ago

Issue #97

codecov-io commented 4 years ago

Codecov Report

Merging #104 into master will decrease coverage by 0.04%. The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   83.96%   83.91%   -0.05%     
==========================================
  Files          31       32       +1     
  Lines        1434     1480      +46     
==========================================
+ Hits         1204     1242      +38     
- Misses        230      238       +8
Impacted Files Coverage Δ
R/plot_aggregated_profiles.R 56.81% <42.85%> (-6.52%) :arrow_down:
R/partial_dependency.R
R/conditional_dependency.R
R/accumulated_dependency.R
R/accumulated_dependence.R 92.85% <0%> (ø)
R/conditional_dependence.R 96.42% <0%> (ø)
R/partial_dependence.R 96.42% <0%> (ø)
R/bind_plots.R 100% <0%> (ø)
R/describe_feature_importance.R 95.45% <0%> (+0.21%) :arrow_up:
R/plot_feature_importance.R 96% <0%> (+0.44%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6500210...b902268. Read the comment docs.

pbiecek commented 4 years ago

Thank you. Can you please expose the title and subtitle as arguments of the plot.aggregated_profiles_explainer() function. So the signature will be 

plot.aggregated_profiles_explainer(... ..., title = "default value...", subtitle = "default value...")

This way the code will be more elastic.

jakwisn commented 4 years ago

I am sorry, but right now I am away for winter break. I will do it as soon as i am back from my holidays, so unfortunately not untill next Saturday/Sunday. I hope it is not to late.

pbiecek commented 4 years ago

no problem, let me know once it is completed

Yue-Jiang commented 4 years ago

Codecov Report

Merging #104 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   83.96%   83.91%   -0.05%     
==========================================
  Files          31       32       +1     
  Lines        1434     1480      +46     
==========================================
+ Hits         1204     1242      +38     
- Misses        230      238       +8
Impacted Files Coverage Δ
R/accumulated_dependency.R
R/conditional_dependency.R
R/partial_dependency.R
R/accumulated_dependence.R 92.85% <0.00%> (ø)
R/conditional_dependence.R 96.42% <0.00%> (ø)
R/partial_dependence.R 96.42% <0.00%> (ø)
R/bind_plots.R 100.00% <0.00%> (ø)
R/describe_feature_importance.R 95.45% <0.00%> (+0.21%) :arrow_up:
R/plot_feature_importance.R 96.00% <0.00%> (+0.44%) :arrow_up:
R/show_aggregated_profiles.R 85.71% <0.00%> (+1.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6500210...b902268. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f186938). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   84.52%           
=========================================
  Files             ?       32           
  Lines             ?     1480           
  Branches          ?        0           
=========================================
  Hits              ?     1251           
  Misses            ?      229           
  Partials          ?        0
Impacted Files Coverage Δ
R/describe_aggregated_profiles.R 68.24% <ø> (ø)
R/plot_aggregated_profiles.R 75% <100%> (ø)
R/accumulated_dependence.R 96.42% <100%> (ø)
R/plot_feature_importance.R 96% <100%> (ø)
R/partial_dependence.R 96.42% <100%> (ø)
R/show_aggregated_profiles.R 85.71% <100%> (ø)
R/aggregate_profiles.R 77.21% <100%> (ø)
R/describe_feature_importance.R 95.45% <100%> (ø)
R/plotD3_aggregated_profiles.R 92.3% <100%> (ø)
R/conditional_dependence.R 96.42% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f186938...fc5ffc7. Read the comment docs.

Yue-Jiang commented 4 years ago

Codecov Report

Merging #104 into master will increase coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   84.31%   84.52%   +0.21%     
==========================================
  Files          32       32              
  Lines        1466     1480      +14     
==========================================
+ Hits         1236     1251      +15     
+ Misses        230      229       -1
Impacted Files Coverage Δ
R/accumulated_dependence.R 96.42% <0.00%> (+3.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b614fe5...fc5ffc7. Read the comment docs.