search

ModelOriented / ingredients

Effects and Importances of Model Ingredients
https://modeloriented.github.io/ingredients/
GNU General Public License v3.0
37 stars 18 forks source link

NOTE in winbuilder #149

Closed pbiecek closed 1 year ago

pbiecek commented 1 year ago 
* checking R code for possible problems ... [10s] NOTE
Found if() conditions comparing class() to string:
File 'ingredients/R/aggregate_profiles.R': if (class(all_profiles) != "data.frame") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (!class(variables) == "character") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (class(x[, "_x_"]) == "numeric") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (class(df[, variables]) == "factor" | class(df[, variables]) == "character") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (!class(variables) == "character") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (class(x[, variables]) == "numeric") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (class(df[, variables]) == "factor" | class(df[, variables]) == "character") ...
File 'ingredients/R/describe_feature_importance.R': if (!(class(nonsignificance_treshold) == "numeric")) ...
Use inherits() (or maybe is()) instead.