Closed expectopatronum closed 4 years ago
Hi, I am glad to see this checklist! Here are some notes:
modelStudio
package is a part of the DrWhy.AI universe (it is stated in README.md
) and more information can be found there.README.md
). It automatically installs dependencies (other R packages that are stated in Depends/Imports in the DESCRIPTION
file with all of their dependencies and so on). The glmnet
package is an import for ingredients
package (very heavy though). I will try to remove it from Imports in the ingredients
package. glmnet
usage is in development stage and it is not needed for the modelStudio
package.tests
folder. Continuous integration is made possible by Travis CI. Basically it will test code on every commit/pull request on this repository. This package is also tested by CRAN and complies with their (for some people strict) policies. Results of this checks (for different OS) can be found here. CONTRIBUTING.md
file to the repo.I remain at your disposal for any further questions :smile:
Thanks, this resolves my questions/concerns!
Hi, I am one of the reviewers for your JOSS submission. I thought I'd put the things I miss in the documentation and the corresponding review checklist items here:
glmnet
for which it requiresgcc-fortran
(which I had to install using my package manager). First I am wondering why it knew that it had to install glmnet - it is not mentioned in this libraries DESCRIPTION (I assume it is a dependency of one of the other packages?) And I am also not sure if it is required that your README mentions that one might need to installgcc-fortran
(because it is not directly used by your package). Just wanted to let you know that this might be an issue :)