ModelOriented / shapper

An R wrapper of SHAP python library
https://modeloriented.github.io/shapper/
58 stars 16 forks source link

Error in rounding_function when running plot() function #39

Open ferygood opened 1 year ago

ferygood commented 1 year ago

Dear maintainer,

Thank you for developing this interesting package. I was following your tutorial using random forest model for classification problem. I faced some problem when I tried using the plot() function:

library("shapper")
library("DALEX")
library("randomForest")
Y_train <- HR$status
x_train <- HR[ , -6]
set.seed(123)
model_rf <- randomForest(x = x_train, y = Y_train, ntree= 50)
p_function <- function(model, data) predict(model, newdata = data, type = "prob")
ive_rf <- individual_variable_effect(model_rf, data = x_train, predict_function = p_function,
                                     new_observation = x_train[1:2,], nsamples = 50)

plot(ive_rf) # error occur when running the plot function

error message:

Error in rounding_function(variable_values[numeric_values], digits) : 
  non-numeric argument to mathematical function

Could you give me some suggestions on how to fix this issue? Thank you very much for your time!

weeleon commented 1 year ago

Hi developer(s), I can reproduce the exact same error above as the original post. Also on my own private datasets. Please advise workaround or if there is a fix for this issue. I see it has been open since Nov 2022. Thanks in advance.

maksymiuks commented 1 year ago

Hi @weeleon

I'm on it

golfr32 commented 1 year ago

@maksymiuks does this issue fix?

maksymiuks commented 1 year ago

This should work know @golfr32 please check master branch of shapper

parsifal9 commented 10 months ago

I can confirm that a new install from github fixed this problem for me. Thanks!