search

ModelSEED / ModelSEEDDatabase

This repository contains the definitive copy of the biochemistry and metadata used to construct models using the ModelSEED/ProbAnno approach
Other
52 stars 38 forks source link

Updating validation to avoid printing out duplicates and to use consi… #140

Closed samseaver closed 5 years ago

samseaver commented 5 years ago

…stent reaction balancing

samseaver commented 5 years ago

I edited to avoid printing out all duplicates, and to make sure that the reaction balancing code is consistent to avoid repeatedly failing the CI test.

Ideally, I'd like to migrate from using the *_Helpers.py in the Scripts directory, but I've not got the patience for it right now.

samseaver commented 5 years ago

This worked, and ran fine, the new unbalanced errors refers to how we check balance for both mass and charge, as far as I can see. Next time we run it, they shouldn't show up again @JamesJeffryes can you confirm?

JamesJeffryes commented 5 years ago

That's right, the errors should reset the baseline

On Wed, Apr 10, 2019 at 4:17 PM Sam Seaver notifications@github.com wrote:

This worked, and ran fine, the new unbalanced errors refers to how we check balance for both mass and charge, as far as I can see. Next time we run it, they shouldn't show up again @JamesJeffryes https://github.com/JamesJeffryes can you confirm?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ModelSEED/ModelSEEDDatabase/pull/140#issuecomment-481868754, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGfOXetQ2omUTpHwQiPY_Jkk5khzJTPks5vflTSgaJpZM4cn9TC .