ModelSEED / ModelSEEDDatabase

This repository contains the definitive copy of the biochemistry and metadata used to construct models using the ModelSEED/ProbAnno approach
Other
53 stars 38 forks source link

Placeholder issue for reactions with charged protein reagents #26

Open samseaver opened 8 years ago

samseaver commented 8 years ago

This issue concerns reactions where the one or more reagents are proteins, typically with a side-group/chain that's involved in the reaction, and the status indicates a charge imbalance.

A recent commit shows that, rather than attempt to balance the reaction by editing the charge itself, which may have undesired consequences in many other reactions, the individual reactions are "cleared" to be OK by manually appending the "OK|CK" keyword where "CK" means "Checked":

https://github.com/ModelSEED/ModelSEEDDatabase/commit/052d83b9a9c8788fdef38422a180650e27a9c319

I'm not altogether comfortable with this solution, but I don't have the time right now to find an appropriate balance, or to determine if its at all possible. As one colleague describes it, "it's like pushing down bumps in a newly laid carpet, new bumps arise in other places". Nevertheless, this issue is placed here to remind us we have such an issue, and we should take a closer look at it at some point.