ModelSEED / ModelSEEDDatabase

This repository contains the definitive copy of the biochemistry and metadata used to construct models using the ModelSEED/ProbAnno approach
Other
54 stars 38 forks source link

New set of default reaction statuses #71

Closed samseaver closed 7 years ago

samseaver commented 7 years ago

So I re-wrote the code for balancing reactions from Perl to Python, and, following on from the changes made to compound formula, very few of these had their statuses changed (33 reactions). For the most part, the changes are innocuous.

@mmundy42 and @JamesJeffryes can you spot-check a few of these changes, to make sure that they are directly attributed to the compounds involved, and not any possible bugs in my reaction balancing code.

samseaver commented 7 years ago

I should add that, historically, the code for computing the "status" of a reaction would also re-balance it with additional protons if necessary. I've decided to make that a separate step. As you'll see, there's a couple of reactions for which the new status shows that only protons are missing, and I'll be writing a separate script/function that will add protons to the reactions to balance these out.