search

ModelSEED / ModelSEEDDatabase

This repository contains the definitive copy of the biochemistry and metadata used to construct models using the ModelSEED/ProbAnno approach
Other
52 stars 38 forks source link

checking duplicates in Travis #84

Open samseaver opened 6 years ago

samseaver commented 6 years ago

Can we limit all checks in Travis to non-obsolete reactions/compounds?

JamesJeffryes commented 6 years ago

I thought I was doing that... Is it not?

samseaver commented 6 years ago

I didn't know either way, but I'd assumed, given the vast number of duplicate names, that this might've been the case. Can you confirm?

JamesJeffryes commented 6 years ago

I exclude obsolete from checking but you may have a lot of comps named "NULL" or "". I may have to check that. https://github.com/ModelSEED/ModelSEEDDatabase/blob/master/Scripts/Validation/Validate_Compounds_JSON.py#L24

On Wed, Nov 8, 2017 at 3:06 PM, samseaver notifications@github.com wrote:

I didn't know either way, but I'd assumed, given the vast number of duplicate names, that this might've been the case. Can you confirm?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ModelSEED/ModelSEEDDatabase/issues/84#issuecomment-342959519, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGfOeJSCY1yVCCYjmnEc43MJQzFFyOjks5s0hfTgaJpZM4QXB5m .