ModelSurge / sd-webui-comfyui

An extension to integrate ComfyUI workflows into the Webui's pipeline
MIT License
517 stars 33 forks source link

--listen will always load on the local machine the server is running, and will not listen to all no matter what #161

Closed Charmandrigo closed 1 year ago

Charmandrigo commented 1 year ago

as the name says I run this on a different machine and log in locally from my work PC, my webui always listens to 0.0.0.0 which makes it visible on the whole local network. This addon will always listen to 127.0.0.1 (the local machine comfyui is running), it does not work on local network machines connected to webui. I tried to add the cli argument "--listen 0.0.0.0" but did not worked and always publishes the URL on the local machine only. I need it to listen 0.0.0.0:(default port) otherwise I can't see the page

ljleb commented 1 year ago

Does this situation happen in newer versions of comfyui only? I suspect this is a bug caused by refactoring cli args code in recent commits in the comfyui repo: https://github.com/comfyanonymous/ComfyUI/commit/3039b08eb16777431946ed9ae4a63c5466336bff

ljleb commented 1 year ago

Pushed a fix #162 for #160, let me know if it fixes this as well.

ljleb commented 1 year ago

Closing this for now, but will reopen if this is still a problem.

Charmandrigo commented 1 year ago

Pushed a fix #162 for #160, let me know if it fixes this as well.

Thanks! It worked "--listen 0.0.0.0" now makes it accessible on all local network