search

ModelSurge / sd-webui-comfyui

An extension to integrate ComfyUI workflows into the Webui's pipeline
MIT License
504 stars 32 forks source link

can't update neither patch #199

Closed StudioXV closed 8 months ago

StudioXV commented 8 months ago

Hi there, since las updat I get this error... any help? thankyou!

Traceback (most recent call last): File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\custom_extension_injector.py", line 87, in patch_prompt_server_add_routes add_routes_ast_function.body[2].value.args[0].elts[0:0] = [extra_line_of_code.body[0].value] AttributeError: 'For' object has no attribute 'value'

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\comfyui\pre_main.py", line 98, in main() File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\ipc__init.py", line 41, in wrapper return function(*args, **kwargs) File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\comfyui\pre_main.py", line 43, in main patch_comfyui() File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\ipc\init.py", line 41, in wrapper return function(*args, **kwargs) File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\comfyui\pre_main.py", line 85, in patch_comfyui custom_extension_injector.register_webui_extensions() File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\custom_extension_injector.py", line 14, in register_webui_extensions register_custom_scripts(script_paths) File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\ipc\init__.py", line 41, in wrapper return function(*args, **kwargs) File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\custom_extension_injector.py", line 33, in register_custom_scripts patch_prompt_server_add_routes(parsed_class, custom_scripts_path_list) File "C:\GitHub\SuperSD\extensions\sd-webui-comfyui\lib_comfyui\custom_extension_injector.py", line 89, in patch_prompt_server_add_routes raise RuntimeError("Cannot patch comfyui as it is not up to date") RuntimeError: Cannot patch comfyui as it is not up to date

jayododds commented 8 months ago

After uninstalling and reinstalling the plugin in an attempt to get it to see torch (see my previous issue) I get this same error. I have tried setting the ICS dropdown to File System as suggested elsewhere - but that didn't seem to make a difference either.

WhiteKnight666 commented 8 months ago

Same issue... I met the issue too today...And I am sure it is up to date... I don't know why....

WhiteKnight666 commented 8 months ago

Spent 4H in this issue but I cannot find a solution....exhaust...

jayododds commented 8 months ago

As much as I don't want to - I may have to setup a standalone and link it - I was hoping to keep it all in the same automatic folder family, but oh well. 🙃

PladsElsker commented 8 months ago

This is an issue that came up because of an update made in the original ComfyUI repo. I can reproduce the "Cannot patch ComfyUI..." error, they modified code that we rely on for the main patch.

I'll investigate with @ljleb and push a fix today or tomorrow 👍

These kind of issues are expected from time to time because ComfyUI doesn't have a stable versioning system like A1111 does.

PladsElsker commented 8 months ago

Just to cIarify, @jayododds I don't think this is the same issue as you had in #197.

PladsElsker commented 8 months ago

Okay, should be fixed. They added a for loop in the middle of the function, so we were patching the wrong thing. I also updated the error message so that people don't spend 4h trying to fix a non-fixable issue.

StudioXV commented 8 months ago

right now it works for me. The only thing was the comfyui manager were not there. I'm reinstalling sd-webui-conmfyui. it might be there if I'm not wrong.. if not I'll try to do it manually (I'm noob). I'll let you know about the reinstalling. Good job!

StudioXV commented 8 months ago

Everything ok!

jayododds commented 8 months ago

@John-WL even though the issue was unrelated - The update got it running but now I'm onto the white screen in tab issue :) Getting closer! Thanks for your efforts on this!

WhiteKnight666 commented 8 months ago

I updated the new version, but a new issue come up.... It seems a connection issue, I can operate comfyui normally now, but I don't if it will lead to other problems... [ComfyUI] To see the GUI go to: http://127.0.0.1:8189 Exception in thread Thread-8 (): Traceback (most recent call last): File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\connector.py", line 1152, in _create_direct_connection hosts = await asyncio.shield(host_resolved) File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\connector.py", line 874, in _resolve_host addrs = await self._resolver.resolve(host, port, family=self._family) File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\resolver.py", line 33, in resolve infos = await self._loop.getaddrinfo( File "asyncio\base_events.py", line 863, in getaddrinfo File "concurrent\futures\thread.py", line 58, in run File "socket.py", line 955, in getaddrinfo socket.gaierror: [Errno 11004] getaddrinfo failed

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "threading.py", line 1016, in _bootstrap_inner File "threading.py", line 953, in run File "E:\Stable diffusion\sd-webui-aki-v4.5\extensions\sd-webui-comfyui\ComfyUI\custom_nodes\ComfyUI-Manager__init.py", line 2240, in threading.Thread(target=lambda: asyncio.run(default_cache_update())).start() File "asyncio\runners.py", line 44, in run File "asyncio\base_events.py", line 649, in run_until_complete File "E:\Stable diffusion\sd-webui-aki-v4.5\extensions\sd-webui-comfyui\ComfyUI\custom_nodes\ComfyUI-Manager__init__.py", line 2238, in default_cache_update await asyncio.gather(a, b, c, d) File "E:\Stable diffusion\sd-webui-aki-v4.5\extensions\sd-webui-comfyui\ComfyUI\custom_nodes\ComfyUI-Manager__init.py", line 2226, in get_cache json_obj = await get_data(uri) File "E:\Stable diffusion\sd-webui-aki-v4.5\extensions\sd-webui-comfyui\ComfyUI\custom_nodes\ComfyUI-Manager\init__.py", line 516, in get_data async with session.get(uri) as resp: File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\client.py", line 1141, in aenter__ self._resp = await self._coro File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\client.py", line 536, in _request conn = await self._connector.connect( File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\connector.py", line 540, in connect proto = await self._create_connection(req, traces, timeout) File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\connector.py", line 901, in _createconnection , proto = await self._create_direct_connection(req, traces, timeout) File "E:\Stable diffusion\sd-webui-aki-v4.5\python\lib\site-packages\aiohttp\connector.py", line 1166, in _create_direct_connection raise ClientConnectorError(req.connection_key, exc) from exc aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host raw.githubusercontent.com:443 ssl:default [getaddrinfo failed]

PladsElsker commented 8 months ago

@WhiteKnight666 Are you using 1 or 2 different venvs for your Webui and ComfyUI installation? I could be wrong but I think some ComfyUI code leads to an error in the venv of your A1111 install.